instance_id
stringlengths
10
57
file_changes
listlengths
1
15
repo
stringlengths
7
53
base_commit
stringlengths
40
40
problem_statement
stringlengths
11
52.5k
patch
stringlengths
251
7.06M
zarr-developers__VirtualiZarr-410
[ { "changes": { "added_entities": [ "virtualizarr/readers/hdf/hdf.py:HDFVirtualBackend._find_non_coord_dimension_vars" ], "added_modules": null, "edited_entities": [ "virtualizarr/readers/hdf/hdf.py:HDFVirtualBackend._virtual_vars_from_hdf" ], "edited_modules":...
zarr-developers/VirtualiZarr
9c3d0f90cc79fa20fe33833e244ae28a1ee91f17
HDF reader creating spurious dimension coordinates This is what the output looks like for the kerchunk-based reader: ```python <xarray.Dataset> Size: 16B Dimensions: (dim_0: 2) Dimensions without coordinates: dim_0 Data variables: bar (dim_0) int64 16B ManifestArray<shape=(2,), dtype=int64...
diff --git a/virtualizarr/readers/hdf/hdf.py b/virtualizarr/readers/hdf/hdf.py index 9a0b69e..2b45cd9 100644 --- a/virtualizarr/readers/hdf/hdf.py +++ b/virtualizarr/readers/hdf/hdf.py @@ -371,6 +371,10 @@ class HDFVirtualBackend(VirtualBackend): group_name = "/" variables = {} + non_coor...
zarr-developers__zarr-python-1335
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/storage.py:DirectoryStore._nested_listdir" ], "edited_modules": [ "zarr/storage.py:DirectoryStore" ] }, "file": "zarr/storage.py" } ]
zarr-developers/zarr-python
0bf0b3b3444dd57debc8a6b5eacb6eb5c082c668
NestedDirectoryStore.listdir returns invalid chunk keys ### Zarr version 2.13.6 and current head 0bf0b3b3444dd57debc8a6b5eacb6eb5c082c668 ### Numcodecs version 0.11.0 ### Python Version 3.10.6 ### Operating System Mac ### Installation pip install zarr and built from source ### Description Calling listdir on ...
diff --git a/docs/release.rst b/docs/release.rst index f82c0730..5ebd77c9 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -28,6 +28,8 @@ Bug fixes * Ensure contiguous data is give to ``FSStore``. Only copying if needed. By :user:`Mads R. B. Kristensen <madsbk>` :issue:`1285`. +* NestedDirectoryStore.listd...
zarr-developers__zarr-python-1354
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/hierarchy.py:group" ], "edited_modules": [ "zarr/hierarchy.py:group" ] }, "file": "zarr/hierarchy.py" } ]
zarr-developers/zarr-python
d7d88158c5f4e61d926675f2af9df66e7848bb68
regression using fsspec.mapping.FSMap object to initialize a store ### Zarr version >= v2.13.6 ### Numcodecs version 0.10.2 ### Python Version 3.9.12 ### Operating System Mac ### Installation pip into virutal environment ### Description I'm seeing a regression in the behavior between zarr-python 2.13.3 and...
diff --git a/docs/release.rst b/docs/release.rst index 0098d2e5..a6c32100 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -15,6 +15,17 @@ Release notes # .. warning:: # Pre-release! Use :command:`pip install --pre zarr` to evaluate this release. +.. _release_2.14.2: + +2.14.2 +------ + +Bug fixes...
zarr-developers__zarr-python-1397
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/util.py:normalize_fill_value" ], "edited_modules": [ "zarr/util.py:normalize_fill_value" ] }, "file": "zarr/util.py" } ]
zarr-developers/zarr-python
d54f25c460f8835a0ec9a7b4bc3482159a5608f9
FutureWarning from zarr.open The following code snippet will raise a FutureWarning: ```python import numpy import zarr ...
diff --git a/docs/release.rst b/docs/release.rst index 7442e519..83588bb3 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -52,6 +52,9 @@ Bug fixes * Fix ``ReadOnlyError`` when opening V3 store via fsspec reference file system. By :user:`Joe Hamman <jhamman>` :issue:`1383`. +* Fix ``normalize_fill_value`` ...
zarr-developers__zarr-python-1428
[ { "changes": { "added_entities": [ "zarr/core.py:Array.blocks", "zarr/core.py:Array.get_block_selection", "zarr/core.py:Array.set_block_selection" ], "added_modules": null, "edited_entities": [ "zarr/core.py:Array.__init__" ], "edited_modules":...
zarr-developers/zarr-python
4132f360616a4c8bfa3dd4e979a4793c5d84cdfc
Enhancement: Chunk level access api / indexing by chunk rather than voxel I may be missing something, but zarr currently seems to offers a high level interface to the chunked data that appears to be largely transparent to the fact that the underlying data is in fact chunked (much like HDF5). I've got a few use cases wh...
diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index 8b1d5ccb..a00096bb 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -64,7 +64,7 @@ jobs: with: name: releases path: dist - - uses: pypa/gh-action-pypi-publish@v1.8.6 ...
zarr-developers__zarr-python-1447
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/meta.py:Metadata3._decode_codec_metadata" ], "edited_modules": [ "zarr/meta.py:Metadata3" ] }, "file": "zarr/meta.py" } ]
zarr-developers/zarr-python
98f74d5e362eff88d1022749e82d7bed9d62b7a2
Will V3 compressor codecs require all parameters in array metadata? ### Zarr version v2.14.3 ### Numcodecs version v0.11.0 ### Python Version 3.10 ### Operating System Mac ### Installation pip ### Description The current V3 implementation seems to require a more specific set of paramete...
diff --git a/docs/release.rst b/docs/release.rst index e8d1c440..46bd1f02 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -18,10 +18,14 @@ Release notes Unreleased ---------- -Bug fixes -~~~~~~~~~ +Enhancements +~~~~~~~~~~~~ + +* Allow for partial codec specification in V3 array metadata. + By :user:`Joe H...
zarr-developers__zarr-python-1470
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/util.py:normalize_chunks" ], "edited_modules": [ "zarr/util.py:normalize_chunks" ] }, "file": "zarr/util.py" } ]
zarr-developers/zarr-python
13cdbfff86de2f39d520e6333687e1b434857eca
Chunks are partially initialized as float / Writing chunk fails with 'float' object cannot be interpreted as an integer ### Zarr version v2.15.0 ### Numcodecs version v0.11.0 ### Python Version 3.10.12 ### Operating System Mac ### Installation pip into virtual environment (via poetry) ### Description I am po...
diff --git a/.git-blame-ignore-revs b/.git-blame-ignore-revs index 05fe3dbd..53bf4633 100644 --- a/.git-blame-ignore-revs +++ b/.git-blame-ignore-revs @@ -1,2 +1,2 @@ # lint codebase with black and ruff -4e348d6b80c96da461fd866576c971b8a659ba15 \ No newline at end of file +4e348d6b80c96da461fd866576c971b8a659ba15 diff...
zarr-developers__zarr-python-1499
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/_storage/v3.py:LRUStoreCacheV3.__init__" ], "edited_modules": [ "zarr/_storage/v3.py:LRUStoreCacheV3" ] }, "file": "zarr/_storage/v3.py" }, { "changes": { ...
zarr-developers/zarr-python
f542fca7d0d42ee050e9a49d57ad0f5346f62de3
tifffile.ZarrTiffStore wrapped in zarr.LRUStoreCache fails to read any chunks ### Zarr version 2.16.0 ### Numcodecs version 0.11.0 ### Python Version 3.11.4 ### Operating System Windows ### Installation py -m pip install -U zarr ### Description Since zarr v2.15.0, the `tifffile.ZarrTiffStore` fails to read a...
diff --git a/docs/release.rst b/docs/release.rst index cf1400d3..188edd62 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -27,6 +27,9 @@ Maintenance * Add ``docs`` requirements to ``pyproject.toml`` By :user:`John A. Kirkham <jakirkham>` :issue:`1494`. +* Fixed caching issue in ``LRUStoreCache``. + By :u...
zarr-developers__zarr-python-1724
[ { "changes": { "added_entities": [ "zarr/hierarchy.py:Group._repr_html_", "zarr/hierarchy.py:Group._repr_latex_", "zarr/hierarchy.py:Group._repr_mimebundle_", "zarr/hierarchy.py:Group._repr_svg_", "zarr/hierarchy.py:Group._repr_png_", "zarr/hierarchy.py:Grou...
zarr-developers/zarr-python
2534413e2f8b56d9c64744419628a464d639f1dc
Implement ipython repr methods on Group to prevent expensive lookups ### Zarr version 2.16.1 ### Numcodecs version ... ### Python Version ... ### Operating System ... ### Installation conda ### Description `ipython` will look for 11 custom repr methods (https://ipython.readthedocs.io/en/stable/config/integra...
diff --git a/docs/release.rst b/docs/release.rst index 116393d4..fd48a53b 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -18,6 +18,12 @@ Release notes Unreleased ---------- +Enhancements +~~~~~~~~~~~~ + +* Override IPython ``_repr_*_`` methods to avoid expensive lookups against object stores. + By :user:`...
zarr-developers__zarr-python-1828
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/common.py:ArraySpec.__init__" ], "edited_modules": [ "src/zarr/common.py:ArraySpec" ] }, "file": "src/zarr/common.py" }, { "changes": { "added_en...
zarr-developers/zarr-python
5889e96ca22cdc2f5a1878048b3a859af8743d6c
NumPy 2.0 support NumPy 2.0 is coming out soon ( https://github.com/numpy/numpy/issues/24300 ). NumPy 2.0.0rc1 packages for conda & wheels came out 3 weeks back ( https://github.com/numpy/numpy/issues/24300#issuecomment-2030603395 ) To prepare for NumPy 2.0, it might be worthwhile to start testing against NumPy 2 in...
diff --git a/pyproject.toml b/pyproject.toml index 8244947a..b60b78dc 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -92,6 +92,9 @@ version.source = "vcs" build.hooks.vcs.version-file = "src/zarr/_version.py" [tool.hatch.envs.test] +dependencies = [ + "numpy~={matrix:numpy}", +] extra-dependencies = [ ...
zarr-developers__zarr-python-1875
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/core.py:Array._process_chunk" ], "edited_modules": [ "zarr/core.py:Array" ] }, "file": "zarr/core.py" }, { "changes": { "added_entities": null, ...
zarr-developers/zarr-python
8264acebc5e1671c36bc434f14cac914f5a099e1
Regression in v2.18.0 when setting an item in an object array ### Zarr version v2.18.0 ### Numcodecs version 0.12.1 ### Python Version 3.12 ### Operating System Windows ### Installation via `poetry install` ### Description There seems to be a regression in v2.18.0 (compared to v2.17.2) ...
diff --git a/docs/release.rst b/docs/release.rst index e2f9f3de..a81be463 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -31,6 +31,8 @@ Docs Maintenance ~~~~~~~~~~~ +* Fix a regression when getting or setting a single value from arrays with size-1 chunks. + By :user:`Deepak Cherian <dcherian>` :issue:`187...
zarr-developers__zarr-python-1929
[ { "changes": { "added_entities": [ "src/zarr/array.py:AsyncArray.chunks", "src/zarr/array.py:Array.chunks" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/zarr/array.py:AsyncArray", "src/zarr/array.py:Array" ] },...
zarr-developers/zarr-python
72005d71fe6e78c03870b3e3b28b3bea3f367043
v3 arrays have no `.chunks` attribute Similar to: https://github.com/zarr-developers/zarr-python/issues/1924 V2 arrays have a `.chunks` attribute: https://zarr.readthedocs.io/en/stable/_autoapi/zarr.core.Array.html#zarr.core.Array.chunks V3 arrays don't: ```python import zarr arr = zarr.Array.create(store=za...
diff --git a/src/zarr/array.py b/src/zarr/array.py index 3e6cf553..698894ba 100644 --- a/src/zarr/array.py +++ b/src/zarr/array.py @@ -366,6 +366,15 @@ class AsyncArray: def shape(self) -> ChunkCoords: return self.metadata.shape + @property + def chunks(self) -> ChunkCoords: + if isinstance...
zarr-developers__zarr-python-1940
[ { "changes": { "added_entities": [ "src/zarr/array.py:AsyncArray.path", "src/zarr/array.py:AsyncArray.name", "src/zarr/array.py:AsyncArray.basename", "src/zarr/array.py:Array.path", "src/zarr/array.py:Array.name", "src/zarr/array.py:Array.basename" ], ...
zarr-developers/zarr-python
24e855c765ac82919ba70bbea03108bdcd8078e6
v3 arrays have no `.name` attribute V2 arrays have a `.name`: https://zarr.readthedocs.io/en/stable/_autoapi/zarr.core.Array.html#zarr.core.Array.name V3 arrays don't: ```python import zarr arr = zarr.Array.create(store=zarr.store.MemoryStore(), shape=(10,), chunks=(5,), dtype="i4") arr.name # attribute error...
diff --git a/src/zarr/array.py b/src/zarr/array.py index a45e7c6b..3e6cf553 100644 --- a/src/zarr/array.py +++ b/src/zarr/array.py @@ -378,6 +378,29 @@ class AsyncArray: def attrs(self) -> dict[str, JSON]: return self.metadata.attributes + @property + def path(self) -> str: + """Storage pat...
zarr-developers__zarr-python-1961
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:array" ], "edited_modules": [ "src/zarr/api/asynchronous.py:array" ] }, "file": "src/zarr/api/asynchronous.py" }, { "changes": { ...
zarr-developers/zarr-python
f648b619e53cde809cd516f308ff40f206a742bd
Clean up typing and docs for indexing #1917 ported all indexing variants from the v2 codebase to v3. However, the typing is a mess and the docs are missing. This needs to be addressed before the 3.0 release.
diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index 51fcf085..b54cbe48 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -55,7 +55,7 @@ jobs: with: name: releases path: dist - - uses: pypa/gh-action-pypi-publish@v1.8.14...
zarr-developers__zarr-python-1968
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/abc/codec.py:ArrayBytesCodecPartialDecodeMixin.decode_partial", "src/zarr/abc/codec.py:ArrayBytesCodecPartialEncodeMixin.encode_partial", "src/zarr/abc/codec.py:batching_helper"...
zarr-developers/zarr-python
b3010fcddb5f14aaed51bf456888e636df8c2697
[v3] Accessing data with bools in square bracket notation ### Zarr version v3 ### Numcodecs version 0.12.1 ### Python Version 3.12 ### Operating System Linux ### Description ``` ix = np.random.binomial(1, 0.6, size=z.shape[0]).astype(bool) print(z[ix]) ``` will result in `IndexError( "...
diff --git a/pyproject.toml b/pyproject.toml index d61eadea..5b97feb8 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -183,10 +183,7 @@ extend-select = [ "RUF", ] ignore = [ - "RUF003", "RUF005", - "RUF012", - "RUF015", ] [tool.mypy] diff --git a/src/zarr/abc/codec.py b/src/zarr/abc/codec.p...
zarr-developers__zarr-python-1991
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:create" ], "edited_modules": [ "src/zarr/api/asynchronous.py:create" ] }, "file": "src/zarr/api/asynchronous.py" } ]
zarr-developers/zarr-python
c677da4b0bc3e600b23cad0cea1253b7923810b0
Dask array to_zarr() broken with zarr 3.0.0a1 ### Zarr version 3.0.0a1 ### Numcodecs version 0.11.0 ### Python Version 3.11.9 ### Operating System Linux ### Installation pip ### Description Given a dask array ``array``, ``array.to_zarr(...)`` now fails with an error related to chunk shape: ``` Traceback ...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 6cf7378b..fa63ab46 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -646,7 +646,11 @@ async def create( if zarr_format == 2 and chunks is None: chunks = shape if zarr_format == 3 and chunk_sh...
zarr-developers__zarr-python-1992
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/store/core.py:make_store_path" ], "edited_modules": [ "src/zarr/store/core.py:make_store_path" ] }, "file": "src/zarr/store/core.py" } ]
zarr-developers/zarr-python
b1bb15ad6e70d90207759edffbcf18e72ec41c0f
[v3] Array open with a Path fails in v3 ### Zarr version 3.0.0a1 ### Numcodecs version 0.12.1 ### Python Version 3.11.9 ### Operating System Mac ### Installation pip ### Description In v2 it was fine to pass a `pathlib.Path` for the store parameter, but this is not working in v3. This seems to be an overs...
diff --git a/src/zarr/store/core.py b/src/zarr/store/core.py index 512c8383..caa30d69 100644 --- a/src/zarr/store/core.py +++ b/src/zarr/store/core.py @@ -79,6 +79,8 @@ def make_store_path(store_like: StoreLike | None, *, mode: OpenMode | None = Non if mode is None: mode = "w" # exception to the ...
zarr-developers__zarr-python-2006
[ { "changes": { "added_entities": [ "src/zarr/abc/store.py:Store.__eq__" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/zarr/abc/store.py:Store" ] }, "file": "src/zarr/abc/store.py" }, { "changes": { "added_ent...
zarr-developers/zarr-python
f1bd70311f93991dac7aa5dd85de2f6b89aa31d6
[v3] Test serialization of arrays and groups Arrays and Groups should be able to be round tripped with Python's pickle protocol. We need a test to make sure this works to be sure downstream applications can work with our new APIs.
diff --git a/src/zarr/abc/store.py b/src/zarr/abc/store.py index 70ac9adc..95d55a2c 100644 --- a/src/zarr/abc/store.py +++ b/src/zarr/abc/store.py @@ -83,6 +83,11 @@ class Store(ABC): if self.mode.readonly: raise ValueError("store mode does not support writing") + @abstractmethod + def __e...
zarr-developers__zarr-python-2058
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/abc/metadata.py:Metadata.to_dict" ], "edited_modules": [ "src/zarr/abc/metadata.py:Metadata" ] }, "file": "src/zarr/abc/metadata.py" }, { "changes": { ...
zarr-developers/zarr-python
cbc08873fcee2f0ddd19b9aca6c6bf518d981bc3
allow `null` attributes We currently error if the `attributes` field of `zarr.json` is missing. We should handle this instead of erroring. reported by @joshmoore Edit: data was originally written by tensorstore
diff --git a/src/zarr/abc/metadata.py b/src/zarr/abc/metadata.py index 36edf695..a14ffb8c 100644 --- a/src/zarr/abc/metadata.py +++ b/src/zarr/abc/metadata.py @@ -30,7 +30,7 @@ class Metadata: elif isinstance(value, str): out_dict[key] = value elif isinstance(value, Sequence):...
zarr-developers__zarr-python-2065
[ { "changes": { "added_entities": [ "src/zarr/abc/store.py:Store._get_many" ], "added_modules": null, "edited_entities": [ "src/zarr/abc/store.py:Store.get", "src/zarr/abc/store.py:Store.get_partial_values", "src/zarr/abc/store.py:Store.set_partial_values",...
zarr-developers/zarr-python
19ed733f13924f162d63279f6d3c42eb31de9a31
[v3] Missing array attributes: nbytes, nchunks, nchunks_initialized ### Zarr version 3.0.0a1 ### Numcodecs version 0.12.1 ### Python Version 3.11.9 ### Operating System Mac ### Installation pip ### Description The array attributes `nbytes`, `nchunks`, and `nchunks_initialized` are all missing in v3. ### Ste...
diff --git a/src/zarr/abc/store.py b/src/zarr/abc/store.py index c453733f..42eb18ce 100644 --- a/src/zarr/abc/store.py +++ b/src/zarr/abc/store.py @@ -1,16 +1,24 @@ +from __future__ import annotations + from abc import ABC, abstractmethod from asyncio import gather from collections.abc import AsyncGenerator, Iterabl...
zarr-developers__zarr-python-2128
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "src/zarr/core/common.py" }, { "changes": { "added_entities": [ "src/zarr/core/group.py:AsyncGroup.require_group", "src/zarr/core...
zarr-developers/zarr-python
60b4f57943419d05d831de227ce58ea2fa1997d1
h5py compatibility in v3 Zarr-Python currently supports most of the h5py API in groups/arrays. As part of #1583, we've decided to break this to clean up the core API going forward. Going forward, h5py compatibility could be provided in a set of wrapper classes. Marking this as _help-wanted_!
diff --git a/src/zarr/core/common.py b/src/zarr/core/common.py index aaa30cfc..99ab58fa 100644 --- a/src/zarr/core/common.py +++ b/src/zarr/core/common.py @@ -28,6 +28,7 @@ ZGROUP_JSON = ".zgroup" ZATTRS_JSON = ".zattrs" BytesLike = bytes | bytearray | memoryview +ShapeLike = tuple[int, ...] | int ChunkCoords = tu...
zarr-developers__zarr-python-2158
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:open" ], "edited_modules": [ "src/zarr/api/asynchronous.py:open" ] }, "file": "src/zarr/api/asynchronous.py" }, { "changes": { ...
zarr-developers/zarr-python
5ca080d0fd21dbb2b6a8b101cc99d86de5039f08
`zarr.open` do not allow creating group file [v3] ### Zarr version v3.0.0a2 ### Numcodecs version 0.13.0 ### Python Version 3.x ### Operating System all ### Installation virtualenv in tox ### Description In napari project we have `--pre` test, ant they start failing. As zarr 3 requires positional only argume...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 95adcf29..2b6f9384 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -7,7 +7,7 @@ from typing import TYPE_CHECKING, Any, Literal, cast import numpy as np import numpy.typing as npt -from zarr.core.array impo...
zarr-developers__zarr-python-2180
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:parse_array_metadata" ], "edited_modules": [ "src/zarr/core/array.py:parse_array_metadata" ] }, "file": "src/zarr/core/array.py" }, { "ch...
zarr-developers/zarr-python
45156713a90e580ffc4aab427553aebb83248fac
`storage_transformers` are not an accepted keyword for ArrayV3Metadata ### Zarr version 3.0.0a3 ### Numcodecs version 0.13.0 ### Python Version 3.11.9 ### Operating System Mac ### Installation pip install ### Description The zarr v3 Array metadata spec specfies the `storage_transformers` key can exist, but z...
diff --git a/src/zarr/core/array.py b/src/zarr/core/array.py index fac0facd..fee3169e 100644 --- a/src/zarr/core/array.py +++ b/src/zarr/core/array.py @@ -82,7 +82,14 @@ def parse_array_metadata(data: Any) -> ArrayV2Metadata | ArrayV3Metadata: return data elif isinstance(data, dict): if data["zar...
zarr-developers__zarr-python-2183
[ { "changes": { "added_entities": [ "src/zarr/abc/store.py:Store.__eq__" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/zarr/abc/store.py:Store" ] }, "file": "src/zarr/abc/store.py" }, { "changes": { "added_ent...
zarr-developers/zarr-python
f1bd70311f93991dac7aa5dd85de2f6b89aa31d6
Make the default `zarr_format` infer when reading files? ### Zarr version v3 ### Numcodecs version n/a ### Python Version n/a ### Operating System n/a ### Installation n/a ### Description While working on consolidated metadata, I got myself confused when I did ```pytb store = zarr.store.LocalStore(root="...
diff --git a/src/zarr/abc/store.py b/src/zarr/abc/store.py index 70ac9adc..95d55a2c 100644 --- a/src/zarr/abc/store.py +++ b/src/zarr/abc/store.py @@ -83,6 +83,11 @@ class Store(ABC): if self.mode.readonly: raise ValueError("store mode does not support writing") + @abstractmethod + def __e...
zarr-developers__zarr-python-2198
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:open", "src/zarr/api/asynchronous.py:save_array", "src/zarr/api/asynchronous.py:save_group", "src/zarr/api/asynchronous.py:group", "src/zarr/...
zarr-developers/zarr-python
54060d3ef84a269ed7b7b561bfd62341b359045a
Default to a RemoteStore for (some) string `StoreLike` ### Zarr version v3 ### Numcodecs version n/a ### Python Version n/a ### Operating System n/a ### Installation n/a ### Description Zarr v2 users (either direct, or indirect through libraries like xarray) probably relied on the ability to pass an fsspec U...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 38576d73..58278172 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -194,6 +194,7 @@ async def open( zarr_version: ZarrFormat | None = None, # deprecated zarr_format: ZarrFormat | None = None, p...
zarr-developers__zarr-python-2210
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:create", "src/zarr/api/asynchronous.py:full_like" ], "edited_modules": [ "src/zarr/api/asynchronous.py:create", "src/zarr/api/asynchronou...
zarr-developers/zarr-python
06e3215faab96a8092e7874958f2b700fa362969
[v3] implement `Group.{empty,zeros,ones,full,empty_like, zeros_like,onest_like,full_like}` Many of these are already defined as top level functions and should be easy to port over to the [Group class](https://github.com/zarr-developers/zarr-python/blob/61683be6f13775c3b9fa78b433812ec1fac41786/src/zarr/core/group.py#L50...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 8a1b0c5f..38576d73 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -575,7 +575,7 @@ async def create( chunks: ChunkCoords | None = None, # TODO: v2 allowed chunks=True dtype: npt.DTypeLike | None = ...
zarr-developers__zarr-python-2213
[ { "changes": { "added_entities": [ "src/zarr/core/group.py:AsyncGroup.group_values", "src/zarr/core/group.py:AsyncGroup.array_values", "src/zarr/core/group.py:Group.group_values", "src/zarr/core/group.py:Group.array_values" ], "added_modules": null, "edite...
zarr-developers/zarr-python
32540b4fa98e6d9ca72b29134cf015333acc7c97
Make `Group.arrays` return tuples of `(key, array)` for v2 compatibility ### Zarr version v3 ### Numcodecs version na ### Python Version na ### Operating System na ### Installation na ### Description zarr-python 2.x used `Group.arrays` to return an iterable of key-value pairs `(name, array)`. In 3.x `.arrays...
diff --git a/src/zarr/core/group.py b/src/zarr/core/group.py index a4e1e252..a45c7e1d 100644 --- a/src/zarr/core/group.py +++ b/src/zarr/core/group.py @@ -33,7 +33,7 @@ from zarr.store import StoreLike, StorePath, make_store_path from zarr.store.common import ensure_no_existing_node if TYPE_CHECKING: - from coll...
zarr-developers__zarr-python-2225
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array_spec.py:ArraySpec.__init__" ], "edited_modules": [ "src/zarr/core/array_spec.py:ArraySpec" ] }, "file": "src/zarr/core/array_spec.py" }, { "...
zarr-developers/zarr-python
cd7321b6481e1d64ea21c97de8cd61685804d476
LocalStore.empty() is True if there are empty directories ### Zarr version v3 ### Numcodecs version ? ### Python Version ? ### Operating System ? ### Installation ? ### Description This should ignore empty directories but doesn't https://github.com/zarr-developers/zarr-python/blob/6900754138e37c75f9522339...
diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index bcff0f61..b03ea06b 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -55,7 +55,7 @@ jobs: with: name: releases path: dist - - uses: pypa/gh-action-pypi-publish@v1.10.1...
zarr-developers__zarr-python-2244
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/codecs/_v2.py:V2Compressor._decode_single", "src/zarr/codecs/_v2.py:V2Compressor._encode_single" ], "edited_modules": [ "src/zarr/codecs/_v2.py:V2Compressor" ]...
zarr-developers/zarr-python
4cbb17eb1c0e8aaca0fd32fa02de08dcdd1a01ab
TypeError: 'Blosc' object is not iterable when reading v2 array with Blosc codec ### Zarr version v3 ### Numcodecs version na ### Python Version na ### Operating System na ### Installation na ### Description We get some wires crossed between the [`ArrayV2Metadata.compressor`](https://gi...
diff --git a/src/zarr/codecs/_v2.py b/src/zarr/codecs/_v2.py index c8bc5583..cc6129e6 100644 --- a/src/zarr/codecs/_v2.py +++ b/src/zarr/codecs/_v2.py @@ -8,16 +8,18 @@ from numcodecs.compat import ensure_bytes, ensure_ndarray from zarr.abc.codec import ArrayArrayCodec, ArrayBytesCodec from zarr.core.buffer import ...
zarr-developers__zarr-python-2262
[ { "changes": { "added_entities": [ "src/zarr/abc/store.py:Store.set_if_not_exists", "src/zarr/abc/store.py:ByteSetter.set_if_not_exists" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/zarr/abc/store.py:Store", "src/zarr/a...
zarr-developers/zarr-python
8e2c660383689b9edec2d30a4e6faad8a303cb57
[v3] zarr 3 fails to create child groups ### Zarr version 3.0.0.alpha5 ### Numcodecs version NA ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description The v3 branch is missing some important behavior around the implicit creation of sub-nodes. In 2.x, this behavior existed: `...
diff --git a/src/zarr/abc/store.py b/src/zarr/abc/store.py index c4d0f9df..bd6befce 100644 --- a/src/zarr/abc/store.py +++ b/src/zarr/abc/store.py @@ -172,6 +172,22 @@ class Store(ABC): """ ... + async def set_if_not_exists(self, key: str, value: Buffer) -> None: + """ + Store a key...
zarr-developers__zarr-python-2286
[ { "changes": { "added_entities": null, "added_modules": [ "src/zarr/abc/codec.py:BaseCodec" ], "edited_entities": null, "edited_modules": [ "src/zarr/abc/codec.py:_Codec", "src/zarr/abc/codec.py:ArrayArrayCodec", "src/zarr/abc/codec.py:ArrayBytesCode...
zarr-developers/zarr-python
01346dd8b94d69def538ae0c668b95d184da5261
Fix fill_value encoding for fixed-width string / binary v2 array ### Zarr version v3 ### Numcodecs version na ### Python Version na ### Operating System na ### Installation na ### Description In https://zarr-specs.readthedocs.io/en/latest/v2/v2.0.html#fill-value-encoding, the zarr-v2 sp...
diff --git a/.github/workflows/releases.yml b/.github/workflows/releases.yml index b03ea06b..f694039c 100644 --- a/.github/workflows/releases.yml +++ b/.github/workflows/releases.yml @@ -55,7 +55,7 @@ jobs: with: name: releases path: dist - - uses: pypa/gh-action-pypi-publish@v1.10.2...
zarr-developers__zarr-python-2329
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:AsyncArray.update_attributes" ], "edited_modules": [ "src/zarr/core/array.py:AsyncArray" ] }, "file": "src/zarr/core/array.py" } ]
zarr-developers/zarr-python
cef4552e5fdc4bcc6f21221d86888b90519472d9
[v3] failure to roundtrip attrs when set via dict interface ### Zarr version zarr-3.0.0a8.dev17+g6b11bb8b ### Numcodecs version v0.13 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description Setting an attribute via the `Array.attrs.__setitem__` interface succeeds at updating the...
diff --git a/src/zarr/core/array.py b/src/zarr/core/array.py index ef4921d4..5195db62 100644 --- a/src/zarr/core/array.py +++ b/src/zarr/core/array.py @@ -896,11 +896,14 @@ class AsyncArray(Generic[T_ArrayMetadata]): return replace(self, metadata=new_metadata) async def update_attributes(self, new_attri...
zarr-developers__zarr-python-2348
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/storage/remote.py:RemoteStore.__init__", "src/zarr/storage/remote.py:RemoteStore.from_url" ], "edited_modules": [ "src/zarr/storage/remote.py:RemoteStore" ] ...
zarr-developers/zarr-python
a9d6d74c4a4d4efcdb64015919d0a5685a7e0239
RemoteStore doesn't strip protocol correctly, breaking list operations I've discovered _what I thought was_ a pretty major gap in our support for remote storage. Instead it turns out to be a weird behavior around prefix and protocol stripping with path urls. Unfortunately there is no way to reproduce this afaict wit...
diff --git a/docs/guide/storage.rst b/docs/guide/storage.rst index dfda553c..0019f993 100644 --- a/docs/guide/storage.rst +++ b/docs/guide/storage.rst @@ -72,7 +72,7 @@ that implements the `AbstractFileSystem` API, .. code-block:: python >>> import zarr - >>> store = zarr.storage.RemoteStore("gs://foo/bar", mo...
zarr-developers__zarr-python-2397
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/codecs/sharding.py:_ShardIndex.get_chunk_slice", "src/zarr/codecs/sharding.py:_ShardReader.__getitem__" ], "edited_modules": [ "src/zarr/codecs/sharding.py:_ShardInd...
zarr-developers/zarr-python
e35c4fcfcf91e2f693dd789379657eacddc4332d
[v3] `zarr-python` fails to decode sharded array written by other implementations. ### Zarr version 3.0.0a5 ### Numcodecs version 0.13.0 ### Python Version 3.10.14 ### Operating System Linux ### Installation pip install zarr==3.0.0a5 ### Description It appears as though the implementati...
diff --git a/src/zarr/codecs/sharding.py b/src/zarr/codecs/sharding.py index 2181e9eb..d01e116f 100644 --- a/src/zarr/codecs/sharding.py +++ b/src/zarr/codecs/sharding.py @@ -129,7 +129,7 @@ class _ShardIndex(NamedTuple): if (chunk_start, chunk_len) == (MAX_UINT_64, MAX_UINT_64): return None ...
zarr-developers__zarr-python-2413
[ { "changes": { "added_entities": [ "src/zarr/core/array.py:AsyncArray.append", "src/zarr/core/array.py:Array.append" ], "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:AsyncArray.resize", "src/zarr/core/array.py:Array.shape", "s...
zarr-developers/zarr-python
8a33df7fb0568c92a40c57874e07b68e371a4a59
[v3] AttributeError: 'Array' object has no attribute 'append' ### Zarr version 3.0.0.beta ### Numcodecs version 0.13 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description We need to implement `Array.append` in 3.0 ### Steps to reproduce ```python In [11]: a = np.arange(1000...
diff --git a/src/zarr/core/array.py b/src/zarr/core/array.py index bdafa33f..8c4d797e 100644 --- a/src/zarr/core/array.py +++ b/src/zarr/core/array.py @@ -2,7 +2,7 @@ from __future__ import annotations import json from asyncio import gather -from dataclasses import dataclass, field, replace +from dataclasses import...
zarr-developers__zarr-python-2417
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:create" ], "edited_modules": [ "src/zarr/api/asynchronous.py:create" ] }, "file": "src/zarr/api/asynchronous.py" }, { "changes": { ...
zarr-developers/zarr-python
37fde7defadf13b6894487987e99e098f027dcf6
[v3] `zarr.array` silently ignores `order` kwarg ### Zarr version 3.0.0.beta ### Numcodecs version 0.13 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description Passing `order=F` to `zarr.array` silently ignores the parameter, producing a `C` ordered array. ### Steps to reproduc...
diff --git a/pyproject.toml b/pyproject.toml index 84ec8b9a..e3d8a310 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -183,6 +183,35 @@ features = ['docs'] build = "cd docs && make html" serve = "sphinx-autobuild docs docs/_build --host 0.0.0.0" +[tool.hatch.envs.upstream] +dependencies = [ + 'numpy', # fro...
zarr-developers__zarr-python-2429
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:create", "src/zarr/api/asynchronous.py:open_array" ], "edited_modules": [ "src/zarr/api/asynchronous.py:create", "src/zarr/api/asynchrono...
zarr-developers/zarr-python
6930fe85b41739478a23d4bd55439e04d68d71cc
[v3] support write_empty_chunks ### Zarr version 3.0.0.beta ### Numcodecs version 0.13 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description `write_empty_chunks` was a very useful write-time optimization that we should bring back to 3.0 https://zarr.readthedocs.io/en/stable...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 8b20676e..14078944 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -10,6 +10,7 @@ import numpy.typing as npt from typing_extensions import deprecated from zarr.core.array import Array, AsyncArray, get_arra...
zarr-developers__zarr-python-2434
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/indexing.py:ceildiv", "src/zarr/core/indexing.py:SliceDimIndexer.__iter__" ], "edited_modules": [ "src/zarr/core/indexing.py:ceildiv", "src/zarr/core/in...
zarr-developers/zarr-python
6ce05265472771e922e69012105d2210e3405aa9
[v3] Support zero-sized arrays ### Zarr version 3.0.0a1 ### Numcodecs version 0.12.1 ### Python Version 3.11.9 ### Operating System Mac ### Installation pip ### Description Zero-sized arrays (i.e. arrays where one dimension is zero) are supported in v2, so they should be in v3 too. ### Steps to reproduce `...
diff --git a/src/zarr/core/indexing.py b/src/zarr/core/indexing.py index f1d5fd16..1873d5c8 100644 --- a/src/zarr/core/indexing.py +++ b/src/zarr/core/indexing.py @@ -94,6 +94,8 @@ class Indexer(Protocol): def ceildiv(a: float, b: float) -> int: + if a == 0: + return 0 return math.ceil(a / b) @@...
zarr-developers__zarr-python-2442
[ { "changes": { "added_entities": [ "src/zarr/abc/store.py:Store.is_empty", "src/zarr/abc/store.py:Store.read_only" ], "added_modules": null, "edited_entities": [ "src/zarr/abc/store.py:AccessMode.from_literal", "src/zarr/abc/store.py:Store.__init__", ...
zarr-developers/zarr-python
3ab3607c418855f70754562c50301ec7e10c24ad
[v3] Re-opening an existing RemoteStore V3 group causes the first child to be deleted This is a weird and unexpected behavior ```python import xarray as xr import zarr import s3fs print(xr.__version__, zarr.__version__) # -> ('0.9.7.dev3734+g26081d4f', '3.0.0b1.dev8+g9bbfd88') s3 = s3fs.S3FileSystem() # re...
diff --git a/docs/guide/storage.rst b/docs/guide/storage.rst index 0019f993..69de796b 100644 --- a/docs/guide/storage.rst +++ b/docs/guide/storage.rst @@ -2,7 +2,7 @@ Storage ======= Zarr-Python supports multiple storage backends, including: local file systems, -Zip files, remote stores via ``fspec`` (S3, HTTP, etc...
zarr-developers__zarr-python-2470
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:create" ], "edited_modules": [ "src/zarr/api/asynchronous.py:create" ] }, "file": "src/zarr/api/asynchronous.py" }, { "changes": { ...
zarr-developers/zarr-python
1cc39177483235df698df3148d26997d19a92de9
[v3] default compressor / codec pipeline ### Zarr version 3.0.0.alpha6 ### Numcodecs version N/A ### Python Version N/A ### Operating System N/A ### Installation N/A ### Description In Zarr-Python 2.x, Zarr provided default compressors for most (all?) datatypes. As of now, in 3.0, we don't provide any defaul...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index e859df44..8b20676e 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -17,10 +17,12 @@ from zarr.core.common import ( ChunkCoords, MemoryOrder, ZarrFormat, + parse_dtype, ) from zarr.core.conf...
zarr-developers__zarr-python-2494
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:open_array" ], "edited_modules": [ "src/zarr/api/asynchronous.py:open_array" ] }, "file": "src/zarr/api/asynchronous.py" } ]
zarr-developers/zarr-python
f74e53aca5311ec077da71585dd962c4af7b8a11
Mode 'r+' no longer fails if store doesn't exist with `open_array` ### Zarr version v3.0.0-beta.2 ### Numcodecs version 0.14.0 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description Mode `r+` does not fail properly when the store doesn't exist, and will try to create the array ...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 94ecfee4..3f36614c 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -1097,7 +1097,7 @@ async def open_array( try: return await AsyncArray.open(store_path, zarr_format=zarr_format) except File...
zarr-developers__zarr-python-2512
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:Array.set_coordinate_selection" ], "edited_modules": [ "src/zarr/core/array.py:Array" ] }, "file": "src/zarr/core/array.py" } ]
zarr-developers/zarr-python
501ae9eaf1f5df774b2981db7020a4e6d1490606
Unexpected Vectorized Indexing Setting Behavior ### Zarr version v3.0.0-beta.1 (main) ### Numcodecs version 0.13.0 ### Python Version 3.12 ### Operating System Mac ### Installation `uv` from repo ### Description I think this is vectorized indexing...in any case I think that the followin...
diff --git a/src/zarr/core/array.py b/src/zarr/core/array.py index 71a6f9d3..a6317e7a 100644 --- a/src/zarr/core/array.py +++ b/src/zarr/core/array.py @@ -2881,6 +2881,14 @@ class Array: if hasattr(value, "shape") and len(value.shape) > 1: value = np.array(value).reshape(-1) + if not is_s...
zarr-developers__zarr-python-2515
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/codecs/_v2.py:V2Codec._encode_single" ], "edited_modules": [ "src/zarr/codecs/_v2.py:V2Codec" ] }, "file": "src/zarr/codecs/_v2.py" }, { "changes": { ...
zarr-developers/zarr-python
7be0ac9c41978fd770023276950522808631998e
bug in v2 codec pipeline ### Zarr version main ### Description There is a bug in these lines: `cdata` is not of type bytes in the `else` clause: https://github.com/zarr-developers/zarr-python/blob/eb85ee7ba32df4983b80ae9e60686e7d2f35349e/src/zarr/codecs/_v2.py#L80-L86 cc @normanrz ### Steps to reproduce This...
diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml index 6506f734..6068d000 100644 --- a/.pre-commit-config.yaml +++ b/.pre-commit-config.yaml @@ -7,7 +7,7 @@ default_language_version: python: python3 repos: - repo: https://github.com/astral-sh/ruff-pre-commit - rev: v0.8.0 + rev: v0.8.1 h...
zarr-developers__zarr-python-2548
[ { "changes": { "added_entities": [ "src/zarr/api/asynchronous.py:_infer_overwrite" ], "added_modules": [ "src/zarr/api/asynchronous.py:_infer_overwrite" ], "edited_entities": [ "src/zarr/api/asynchronous.py:_infer_exists_ok", "src/zarr/api/asynchrono...
zarr-developers/zarr-python
4e53a70728c69330bc096877a6172618cb717aa5
Rename `exists_ok` to `overwrite` ### Zarr version main ### Numcodecs version ... ### Python Version ... ### Operating System ... ### Installation ... ### Description ... ### Steps to reproduce ... ### Additional output _No response_
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 26822f72..b5dbb0cf 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -71,7 +71,7 @@ _CREATE_MODES: tuple[AccessModeLiteral, ...] = ("a", "w", "w-") _OVERWRITE_MODES: tuple[AccessModeLiteral, ...] = ("a", "r+", ...
zarr-developers__zarr-python-2576
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:AsyncArray.nbytes", "src/zarr/core/array.py:AsyncArray._info" ], "edited_modules": [ "src/zarr/core/array.py:AsyncArray" ] }, "file": "sr...
zarr-developers/zarr-python
5bf7bcfcfe6426bea37df5d0691211f6a71daa39
Array.nbytes logic is wrong ### Zarr version 3.0.0.b2 ### Numcodecs version ! ### Python Version ! ### Operating System ! ### Installation ! ### Description This logic is obviously and embarrassingly wrong: https://github.com/zarr-developers/zarr-python/blob/f035d453894ec83234f69f7627b540390ee2b6eb/src/zarr...
diff --git a/src/zarr/core/array.py b/src/zarr/core/array.py index e5fc707f..2849907f 100644 --- a/src/zarr/core/array.py +++ b/src/zarr/core/array.py @@ -977,9 +977,17 @@ class AsyncArray(Generic[T_ArrayMetadata]): @property def nbytes(self) -> int: """ - The number of bytes that can be store...
zarr-developers__zarr-python-2583
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:array" ], "edited_modules": [ "src/zarr/api/asynchronous.py:array" ] }, "file": "src/zarr/api/asynchronous.py" } ]
zarr-developers/zarr-python
fb11810170e864aada188f656fdc254d2de82720
[v3] Scalar arrays: IndexError: too many indices for array; expected 0, got 1 ### Zarr version 3.0.0b1 ### Numcodecs version 0.13.1 ### Python Version 3.11 ### Operating System Mac ### Installation pip ### Description In Zarr 2.18, this works: ```python In [1]: import zarr In [2]: arr = zarr.array(1.5...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 14078944..c4d1ec86 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -579,7 +579,7 @@ async def array( z = await create(**kwargs) # fill with data - await z.setitem(slice(None), data) + await z...
zarr-developers__zarr-python-2629
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/api/asynchronous.py:open" ], "edited_modules": [ "src/zarr/api/asynchronous.py:open" ] }, "file": "src/zarr/api/asynchronous.py" } ]
zarr-developers/zarr-python
372995e42dee6f06c69d146d887be0db5b5bfe7b
`zarr.open` do not allow creating zarr group (regressions since zarr 3.0.0b1) ### Zarr version 3.0.0b2 ### Numcodecs version 0.14.0 ### Python Version 3.12 ### Operating System all ### Installation using pip in prerelease version ### Description The latest beta release of zarr 3.0.0b2 the api of creating za...
diff --git a/src/zarr/api/asynchronous.py b/src/zarr/api/asynchronous.py index 75c043fc..f54a8240 100644 --- a/src/zarr/api/asynchronous.py +++ b/src/zarr/api/asynchronous.py @@ -312,7 +312,7 @@ async def open( store_path = await make_store_path(store, mode=mode, path=path, storage_options=storage_options) ...
zarr-developers__zarr-python-2638
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/group.py:AsyncGroup.create_dataset" ], "edited_modules": [ "src/zarr/core/group.py:AsyncGroup" ] }, "file": "src/zarr/core/group.py" } ]
zarr-developers/zarr-python
584d66dd4c2c8ccb5788aa6f9a27bfa76e3166bd
Group.create_dataset does not match 2.x API ### Zarr version 3.0.0rc2.dev1+gc070940e ### Numcodecs version 0.14.1 ### Python Version 3.11.11 ### Operating System macOS 15.1.1 ### Installation editable install from main into a conda env ### Description #2463 broke the signature of `Group.create_dataset`, beca...
diff --git a/src/zarr/core/group.py b/src/zarr/core/group.py index 7a0d2efc..5cb42db5 100644 --- a/src/zarr/core/group.py +++ b/src/zarr/core/group.py @@ -1165,7 +1165,16 @@ class AsyncGroup: .. deprecated:: 3.0.0 The h5py compatibility methods will be removed in 3.1.0. Use `AsyncGroup.create_arra...
zarr-developers__zarr-python-2644
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/_info.py:ArrayInfo.__repr__" ], "edited_modules": [ "src/zarr/core/_info.py:ArrayInfo" ] }, "file": "src/zarr/core/_info.py" }, { "changes": { ...
zarr-developers/zarr-python
0adcbe728d5d286c160974717bddc6e4fb881e5a
Array.info should print shard sizes The `Array.info(_complete)` method should print `Shard shape` for sharded arrays. The current output (see below), where the shard shape is printed as "Chunk shape", may be confusing to users. ```python >>> a = zarr.create_array('data/example-20.zarr', shape=(10000, 10000), shards=...
diff --git a/docs/user-guide/arrays.rst b/docs/user-guide/arrays.rst index b21f8e97..110e12c3 100644 --- a/docs/user-guide/arrays.rst +++ b/docs/user-guide/arrays.rst @@ -574,8 +574,41 @@ Any combination of integer and slice can be used for block indexing:: Sharding -------- -Coming soon. - +Using small chunk shape...
zarr-developers__zarr-python-2652
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/_info.py:ArrayInfo.__repr__" ], "edited_modules": [ "src/zarr/core/_info.py:ArrayInfo" ] }, "file": "src/zarr/core/_info.py" }, { "changes": { ...
zarr-developers/zarr-python
5c6267e69fdd69fd6fb0c5fc74f1de82b9b4b07d
add `compressors`, `filters`, `serializer` to `Array` as attributes #2463 added a new function for creating arrays that abstracts over the painful fact that v2 arrays and v3 arrays have overlapping-but-distinct specifications of how chunks are encoded. This function expresses the v2 and v3 chunk encoding specs via 3 ke...
diff --git a/docs/user-guide/arrays.rst b/docs/user-guide/arrays.rst index 110e12c3..ba85ce1c 100644 --- a/docs/user-guide/arrays.rst +++ b/docs/user-guide/arrays.rst @@ -168,8 +168,8 @@ argument accepted by all array creation functions. For example:: >>> data = np.arange(100000000, dtype='int32').reshape(10000, 10...
zarr-developers__zarr-python-2655
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/metadata/v2.py:ArrayV2Metadata.to_buffer_dict" ], "edited_modules": [ "src/zarr/core/metadata/v2.py:ArrayV2Metadata" ] }, "file": "src/zarr/core/metadata/...
zarr-developers/zarr-python
bb8ab0fa1f847eb95a545cd17af1c6ba51e69f65
Regression with 3.0.0rc1: reading zarr with tensorstore ### Zarr version 3.0.0rc1 ### Numcodecs version 0.14.1 ### Python Version 3.12 ### Operating System macOS, but also all on CI ### Installation pip ### Description With 3.0.0rc1 we observed some fails in napari --pre tests. Juan is already addressing one...
diff --git a/src/zarr/core/metadata/v2.py b/src/zarr/core/metadata/v2.py index b9543306..29cf15a1 100644 --- a/src/zarr/core/metadata/v2.py +++ b/src/zarr/core/metadata/v2.py @@ -116,7 +116,13 @@ class ArrayV2Metadata(Metadata): else: return o.descr if isinstance(o, nu...
zarr-developers__zarr-python-2668
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/group.py:Group.array" ], "edited_modules": [ "src/zarr/core/group.py:Group" ] }, "file": "src/zarr/core/group.py" } ]
zarr-developers/zarr-python
bc5877be4f61895a29fd811882e188f84fa3f8f2
`Group.array` method ignores `data` argument ### Zarr version 3.0.0b3.dev73+g91385283 ### Numcodecs version 0.14.0 ### Python Version 3.11 ### Operating System Mac ### Installation editable install from main into a conda env ### Description The `data` argument to `Group.array` is ignored: https://github.com...
diff --git a/src/zarr/core/group.py b/src/zarr/core/group.py index 82970e4b..79ab3111 100644 --- a/src/zarr/core/group.py +++ b/src/zarr/core/group.py @@ -2729,6 +2729,8 @@ class Group(SyncMixin): Whether to overwrite an array with the same name in the store, if one exists. config : ArrayConfig or...
zarr-developers__zarr-python-2679
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:AsyncArray._get_selection", "src/zarr/core/array.py:AsyncArray._set_selection" ], "edited_modules": [ "src/zarr/core/array.py:AsyncArray" ] }...
zarr-developers/zarr-python
e10b69d72a2d00ffdfa39ac4f4195363fb8e16fd
Regression with `order` when storing V2 arrays ### Zarr version v3.0.0rc2 ### Numcodecs version 0.14.2.dev18 ### Python Version 3.12 ### Operating System Linux ### Installation uv pip install ... ### Description The `order` argument for array creation has been changed for `zarr-python` 3.0.0 to mean the memo...
diff --git a/docs/release-notes.rst b/docs/release-notes.rst index 175bd21a..6703b82d 100644 --- a/docs/release-notes.rst +++ b/docs/release-notes.rst @@ -1,6 +1,20 @@ Release notes ============= +Unreleased +---------- + +New features +~~~~~~~~~~~~ + +Bug fixes +~~~~~~~~~ +* Fixes ``order`` argument for Zarr forma...
zarr-developers__zarr-python-2709
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/zarr/core/array.py:_parse_deprecated_compressor" ], "edited_modules": [ "src/zarr/core/array.py:_parse_deprecated_compressor" ] }, "file": "src/zarr/core/array.py" ...
zarr-developers/zarr-python
168999ceff099799da9ead7c12f38aa9378a831f
In V2, creating an array with compressor=None assumes Zstd ### Zarr version 3.0.1.dev9+g168999ce ### Numcodecs version - ### Python Version 3.12 ### Operating System linux ### Installation manual from source ### Description In zarr V2, creating an array would assume the default compression (blosc); to get un...
diff --git a/docs/release-notes.rst b/docs/release-notes.rst index 2e573282..ecd41351 100644 --- a/docs/release-notes.rst +++ b/docs/release-notes.rst @@ -13,6 +13,8 @@ Bug fixes * Fixes a bug that prevented reading Zarr format 2 data with consolidated metadata written using ``zarr-python`` version 2 (:issue:`2694`)...
zarr-developers__zarr-python-455
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "zarr/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/hierarchy.py:_...
zarr-developers/zarr-python
c4d7f49f67b42d562e55d40c761dd98c2cbc33b2
Renaming DictStore Some discussion in PR ( https://github.com/zarr-developers/zarr/pull/350 ) raised the point that the name `DictStore` may not itself be clear. As such it may be better to rename it to something that makes its intent clear (with some backcompat support like aliasing to the old name with a deprecation ...
diff --git a/docs/api/storage.rst b/docs/api/storage.rst index 85d85f40..a2aff3b6 100644 --- a/docs/api/storage.rst +++ b/docs/api/storage.rst @@ -2,7 +2,7 @@ Storage (``zarr.storage``) ========================== .. automodule:: zarr.storage -.. autoclass:: DictStore +.. autoclass:: MemoryStore .. autoclass:: Dire...
zarr-developers__zarr-python-459
[ { "changes": { "added_entities": [ "zarr/storage.py:DirectoryStore._normalize_key" ], "added_modules": null, "edited_entities": [ "zarr/storage.py:DirectoryStore.__init__", "zarr/storage.py:DirectoryStore.__getitem__", "zarr/storage.py:DirectoryStore.__set...
zarr-developers/zarr-python
65362506066699d66c807bcc5020e95f2f013c33
Case insensitivity and DirectoryStore The matching of keys in a DirectoryStore will depend on the underlying file system. If a DirectoryStore is running on a case-sensitive file system, as is usually default on most linux systems, then keys like 'foo' and 'FOO' will appear as distinct. However, if on a case-insensitive...
diff --git a/docs/release.rst b/docs/release.rst index f4f99c2e..e87696b9 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -4,8 +4,12 @@ Release notes Upcoming Release ---------------- +* Add key normalization option for ``DirectoryStore``, ``NestedDirectoryStore``, + ``TempStore``, and ``N5Store``. + By :...
zarr-developers__zarr-python-517
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/creation.py:normalize_store_arg" ], "edited_modules": [ "zarr/creation.py:normalize_store_arg" ] }, "file": "zarr/creation.py" }, { "changes": { "add...
zarr-developers/zarr-python
be29d3659daf83b8ff2b119ac98d97c47324706c
permission problem in zarr.ZipStore #### Minimal, reproducible code sample, a copy-pastable example if possible ```python import numpy as np import pandas as pd import xarray as xr import zarr import os # create dataset from xarray documentation temp = 15 + 8 * np.random.randn(2, 2, 3) precip = 10 * np.ran...
diff --git a/docs/release.rst b/docs/release.rst index a10dd934..00a80242 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -4,6 +4,10 @@ Release notes Upcoming Release ---------------- +* Add intermediate step (using ``zipfile.ZipInfo`` object) to write + inside ``ZipStore`` to solve too restrictive permiss...
zarr-developers__zarr-python-659
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/convenience.py:copy_all" ], "edited_modules": [ "zarr/convenience.py:copy_all" ] }, "file": "zarr/convenience.py" } ]
zarr-developers/zarr-python
da4f790ace08ae9ee2ff25289a7d3f40c6ecb61a
copy_all() does not copy group attributes #### Minimal example ```python import zarr # setup group in memory store store_mem = zarr.MemoryStore() group_mem = zarr.group(store = store_mem, overwrite=True) group_mem.attrs['info'] = 'group attrs' # setup group in directory store data_path = 'tmp/example.za...
diff --git a/docs/release.rst b/docs/release.rst index af0b1ab3..a5f78908 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -13,6 +13,8 @@ This release will be the first release of Zarr not supporting Python 3.5. * Add `Array` tests for FSStore. By :user:`Andrew Fulton <andrewfulton9>`; :issue: `644`. +* fi...
zarr-developers__zarr-python-665
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/core.py:Array.fill_value" ], "edited_modules": [ "zarr/core.py:Array" ] }, "file": "zarr/core.py" } ]
zarr-developers/zarr-python
f2feb5a5264e0b183019f1b3e3bf947b030bf1fe
Modify fill_value on existing arrays There is currently no way to chance the fill_value on an existing array (without hacking the metadata). We allow existing arrays to be resized. Why not allow to change the fill_value?
diff --git a/docs/release.rst b/docs/release.rst index d0aed556..801dcbe8 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -9,6 +9,8 @@ Unreleased Enhancements ~~~~~~~~~~~~ +* Allow to assign array ``fill_values`` and update metadata accordingly. :issue:`662` + * array indexing with [] (getitem and setitem)...
zarr-developers__zarr-python-832
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/creation.py:create" ], "edited_modules": [ "zarr/creation.py:create" ] }, "file": "zarr/creation.py" } ]
zarr-developers/zarr-python
5b0437537dc6e9067c9627857aacfc7e873439ac
Explicitely specified dimension_separator conflicts with default When using convenience methods with a path/url, specifying the dimension separator causes an error. #### Minimal, reproducible code sample, a copy-pastable example if possible ```python import numpy as np import zarr data = np.arange(6).reshape((...
diff --git a/requirements_dev_optional.txt b/requirements_dev_optional.txt index f4f1c59e..e2d5da4a 100644 --- a/requirements_dev_optional.txt +++ b/requirements_dev_optional.txt @@ -12,7 +12,7 @@ types-redis types-setuptools pymongo==3.12.0 # optional test requirements -tox==3.24.3 +tox==3.24.4 coverage flake8==3...
zarr-developers__zarr-python-911
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/storage.py:FSStore.__init__" ], "edited_modules": [ "zarr/storage.py:FSStore" ] }, "file": "zarr/storage.py" } ]
zarr-developers/zarr-python
d1f590dffd37684aad7c9fbc19ed9974441ed325
Cannot create FSStore for unlistable http URLs #### Minimal, reproducible code sample, a copy-pastable example if possible ```python import zarr import fsspec # public url = 'https://g-c70289.0da32.08cc.data.globus.org/pyqg_ensemble/001.zarr' # this errors store = zarr.storage.FSStore(url) # because o...
diff --git a/docs/release.rst b/docs/release.rst index 7a5cf51d..cd9ebbd7 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -9,6 +9,27 @@ Unreleased Bug fixes ~~~~~~~~~ +* Fix bug that made it impossible to create an ``FSStore`` on unlistable filesystems + (e.g. some HTTP servers). + By :user:`Ryan Abernath...
zarr-developers__zarr-python-933
[ { "changes": { "added_entities": [ "zarr/util.py:NumberEncoder.default" ], "added_modules": [ "zarr/util.py:NumberEncoder" ], "edited_entities": [ "zarr/util.py:json_dumps" ], "edited_modules": [ "zarr/util.py:json_dumps" ] }, ...
zarr-developers/zarr-python
18abb190977eeb575c94dbb601fd709cfe27a990
NumPy integers not accepted in `chunks` argument to `zarr.zeros` The following code works with zarr 2.3.2, but not with more-recently-released versions of zarr (tested on zarr 2.4.0 and zarr 2.6.1). It now gives a `TypeError` as a result of attempting to JSON serialize a NumPy integer. ```python import numpy as np ...
diff --git a/docs/release.rst b/docs/release.rst index 13c2f20d..7a5cf51d 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -14,6 +14,9 @@ Bug fixes value when empty chunks are read back in. By :user:`Vyas Ramasubramani <vyasr>`; :issue:`965`. +* Add number encoder for ``json.dumps`` to support numpy inte...
zarr-developers__zarr-python-976
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zarr/convenience.py:open", "zarr/convenience.py:save_array", "zarr/convenience.py:save_group", "zarr/convenience.py:consolidate_metadata", "zarr/convenience.py:open_conso...
zarr-developers/zarr-python
84d8f7cf6a3f8f398b272761f01b02bdebcbf9df
Open mode is lost when opening via FSStore This issue describes failed writes to xarray groups using `FSStore` where I'd expect the write to succeed. My current assumption is, that these issues occure due to mode-flags getting lost when the store is created implicitly (i.e. only an url is passed to zarr functions). I d...
diff --git a/docs/release.rst b/docs/release.rst index 16c884ef..c1ca0355 100644 --- a/docs/release.rst +++ b/docs/release.rst @@ -6,6 +6,14 @@ Release notes Unreleased ---------- + +Bug fixes +~~~~~~~~~ + +* Removed `clobber` argument from `normalize_store_arg`. This enables to change + data within a opened conso...
zephyrproject-rtos__west-189
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/west/_bootstrap/main.py:clone_west" ], "edited_modules": [ "src/west/_bootstrap/main.py:clone_west" ] }, "file": "src/west/_bootstrap/main.py" }, { "changes...
zephyrproject-rtos/west
6e92ce70a730d116b37ecebd12b715756ad444f6
Create a command line interface for dealing with manifests We need a way to deal with the west manifest from the command line. At the very least, this needs to cover creating a "frozen" or "pinned" manifest file which nails down the revisions of west and every project. The interface would look like this: ``` wes...
diff --git a/src/west/_bootstrap/main.py b/src/west/_bootstrap/main.py index 00d9dc1..e9dc9a1 100644 --- a/src/west/_bootstrap/main.py +++ b/src/west/_bootstrap/main.py @@ -336,6 +336,11 @@ def clone_west(manifest_file, directory): clone('west repository', west_url, west_rev, os.path.join(directory, WES...
zephyrproject-rtos__west-362
[ { "changes": { "added_entities": [ "src/west/app/main.py:LogFormatter.__init__", "src/west/app/main.py:LogHandler.__init__", "src/west/app/main.py:LogHandler.emit", "src/west/app/main.py:WestApp.setup_logging" ], "added_modules": [ "src/west/app/main.py:...
zephyrproject-rtos/west
2101a7af38bedf2a3ea2c6cb1f70834b7151a9fb
Logging for imported projects being added is wrong The west.manifest logging calls for when projects are being added is wrong. The recursive call to the Manifest constructor is logging the addition of a project, and then it happens again in the parent manifest level of the recursion tree. The logging calls need to h...
diff --git a/src/west/app/main.py b/src/west/app/main.py index a22cba5..5aeba9c 100755 --- a/src/west/app/main.py +++ b/src/west/app/main.py @@ -38,6 +38,33 @@ from west.manifest import Manifest, MalformedConfig, MalformedManifest, \ from west.util import quote_sh_list, west_topdir, WestNotFound from west.version imp...
zeshuaro__LinkedRW-29
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "linkedrw/__init__.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_module...
zeshuaro/LinkedRW
f5d189b19870af549eeb8006d1863e9927af2164
Error when using Hello I am trying to use this but i get the error using both chrome driver and firefox driver >>> Enter your LinkedIn login email: fastah@gmail.com Enter your LinkedIn login password: [2019-06-02 16:16:46] NOTICE: Scraping LinkedIn profile [2019-06-02 16:16:46] NOTICE: Please keep the browser w...
diff --git a/linkedrw/__init__.py b/linkedrw/__init__.py index e9b95b7..8ef52e7 100644 --- a/linkedrw/__init__.py +++ b/linkedrw/__init__.py @@ -1,4 +1,4 @@ from .main import main -__version__ = "1.1.5" +__version__ = "1.1.6" VERSION = __version__ diff --git a/linkedrw/constants.py b/linkedrw/constants.py index f4e...
zhmcclient__python-zhmcclient-142
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_manager.py:BaseManager.findall" ], "edited_modules": [ "zhmcclient/_manager.py:BaseManager" ] }, "file": "zhmcclient/_manager.py" } ]
zhmcclient/python-zhmcclient
ca4b1e678e3568e3c95143ba8544d2982e6ac40b
Regression: findall() raises NotFound Error when searching by name and nothing was found ### Actual behavior _manager.findall(name=foo) raises NotFound exception when nothing was found ### Expected behavior Empty list returned ### Execution environment * zhmcclient version: 0.8.0 + master * Operating system...
diff --git a/zhmcclient/_manager.py b/zhmcclient/_manager.py index e3d95aa..06e0c28 100644 --- a/zhmcclient/_manager.py +++ b/zhmcclient/_manager.py @@ -198,8 +198,11 @@ class BaseManager(object): """ found = list() if list(kwargs.keys()) == ['name']: - obj = self.find_by_name(kwar...
zhmcclient__python-zhmcclient-217
[ { "changes": { "added_entities": [ "zhmcclient_mock/_hmc.py:FakedPartition.wwpn_alloc", "zhmcclient_mock/_hmc.py:FakedPartition.wwpn_free", "zhmcclient_mock/_hmc.py:FakedPartition.wwpn_free_if_allocated" ], "added_modules": null, "edited_entities": [ "zhmc...
zhmcclient/python-zhmcclient
c52016859aae083f10ef7be7ebef87b60a54554c
WWPN is not attaching in mock frmework In mock framework when we create hba then it should also attach 'wwpn'. But as of now it is not attaching. self.partition.hbas[0].get_property('wwpn')
diff --git a/docs/changes.rst b/docs/changes.rst index 3072f69..7b7c868 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -31,6 +31,8 @@ Released: not yet **Bug fixes:** +* Added WWPN support in mocking framework (issue #212). + **Enhancements:** **Known Issues:** diff --git a/zhmcclient_mock/_hmc.py b/z...
zhmcclient__python-zhmcclient-218
[ { "changes": { "added_entities": [ "zhmcclient_mock/_hmc.py:FakedBaseResource.__repr__", "zhmcclient_mock/_hmc.py:FakedBaseManager.__repr__", "zhmcclient_mock/_hmc.py:FakedHmc.__repr__" ], "added_modules": null, "edited_entities": [ "zhmcclient_mock/_hmc.p...
zhmcclient/python-zhmcclient
560cdaa7fda0f63688efa192cbfe711324a194ea
zhmccliet_mock framework- partition start stop works with different partition object ### Actual behavior partition.delete() invokation followed with query of status parameter on Partition fails File "nova_dpm/virt/dpm/vm.py", line 315, in destroy if (self.partition.properties['status'] == 'stopped'): ...
diff --git a/docs/changes.rst b/docs/changes.rst index c6b5f3b..4abc74c 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -33,8 +33,32 @@ Released: not yet * Added WWPN support in mocking framework (issue #212). +* Fixed error in mock support where the `operation_timeout` argument to + `FakedSession.post()`...
zhmcclient__python-zhmcclient-229
[ { "changes": { "added_entities": [ "zhmcclient/_session.py:Job.op_method", "zhmcclient/_session.py:Job.op_uri" ], "added_modules": null, "edited_entities": [ "zhmcclient/_session.py:Session.post", "zhmcclient/_session.py:Job.__init__", "zhmcclient/...
zhmcclient/python-zhmcclient
c829a05248bcbb05c23c50ecde4a1ca33010b9d3
Starting a paused partition fails ### Actual behavior This is the expected behavior by DPM (confirmed that) - but it's really strange. For nova-dpm we need ot fix it - the question is, if we fix it in zhmcclient or in nova-dpm. - do an inband shutdown of a partition (e.g. via linux shell: shutdown -P now) - parti...
diff --git a/docs/changes.rst b/docs/changes.rst index 3c7bbd6..3075dd5 100755 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -48,6 +48,8 @@ Released: not yet * Improved robustness of timestats tests by measuring the actual sleep time instead of going by the requested sleep time. +* Added support for 'error' ...
zhmcclient__python-zhmcclient-286
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_timestats.py:TimeStatsKeeper.snapshot", "zhmcclient/_timestats.py:TimeStatsKeeper.__str__" ], "edited_modules": [ "zhmcclient/_timestats.py:TimeStatsKeeper" ...
zhmcclient/python-zhmcclient
077e1ada5272d57143f1d453568ac5dd9daa6a8c
TimeStatsKeeper.snapshot() result not very handy The `TimeStatsKeeper.snapshot()` method returns a list of tuples (op_name, TimeStats), which it produces by appliying the `items()` method on the internal dictionary. Most uses of the snapshot I have seen so far, transform that back into a dictionary by using `dict(sn...
diff --git a/docs/changes.rst b/docs/changes.rst index f6dccff..51adb06 100755 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -27,6 +27,10 @@ Released: not yet **Incompatible changes:** +* Changed the return value of ``TimeStatsKeeper.snapshot()`` from a list of + key/value tuples to a dictionary. This is more ...
zhmcclient__python-zhmcclient-329
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_activation_profile.py:ActivationProfileManager.__init__", "zhmcclient/_activation_profile.py:ActivationProfileManager.list" ], "edited_modules": [ "zhmcclient/_ac...
zhmcclient/python-zhmcclient
b6f8b75700b71d27da0303047e3c237623bca38a
Performance issue with "find()" when filtering on "object-id" Is "find" method is iterates over items? For example cpc.adapters.find(**{'object-id': 'xxxxxxxx'}) If it iterates over items then we should have DPM API to filter item for better performance.
diff --git a/zhmcclient/_activation_profile.py b/zhmcclient/_activation_profile.py index bc0e538..0734caa 100644 --- a/zhmcclient/_activation_profile.py +++ b/zhmcclient/_activation_profile.py @@ -104,6 +104,8 @@ class ActivationProfileManager(BaseManager): resource_class=ActivationProfile, se...
zhmcclient__python-zhmcclient-443
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient_mock/_urihandler.py:MetricsContextsHandler.post", "zhmcclient_mock/_urihandler.py:MetricsContextHandler.delete", "zhmcclient_mock/_urihandler.py:MetricsContextHandler.get" ...
zhmcclient/python-zhmcclient
6b163ed76601e39d54eadd28577bdb18ad82181d
zhmcclient_mock/_urihandler.py:315: TypeError [test_27.log.txt](https://github.com/zhmcclient/python-zhmcclient/files/1309064/test_27.log.txt) ### Actual behavior MetricsContextHandlersTests.test_create_get_delete_context fails due to a TypeError in file zhmcclient_mock/_urihandler.py, line 315. This unit test...
diff --git a/zhmcclient_mock/_urihandler.py b/zhmcclient_mock/_urihandler.py index 3124ff2..d703b52 100644 --- a/zhmcclient_mock/_urihandler.py +++ b/zhmcclient_mock/_urihandler.py @@ -503,10 +503,11 @@ class CpcExportPortNamesListHandler(object): class MetricsContextsHandler(object): @staticmethod - def pos...
zhmcclient__python-zhmcclient-456
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_session.py:Session.__init__" ], "edited_modules": [ "zhmcclient/_session.py:Session" ] }, "file": "zhmcclient/_session.py" } ]
zhmcclient/python-zhmcclient
f67d075e5f00522a32d60f5f5966956d3c66a5b2
Error "fixture 'capture' not found" on Py34+36 when migrating test_logging to pytest ### Actual behavior When migrating the test_logging.py testcases from unittest to pytest, the following error happens on Python 3.4 and 3.6 (but not on 2.7): ``` $ PYTHONPATH=. py.test -s -x test_pt.py . . . file /media/share/...
diff --git a/.travis.yml b/.travis.yml index db14ec8..6ee16b1 100644 --- a/.travis.yml +++ b/.travis.yml @@ -30,26 +30,41 @@ matrix: python: "3.4" env: - PACKAGE_LEVEL=minimum - - os: linux - language: python - python: "3.5" - env: - - PACKAGE_LEVEL=minimum - before_...
zhmcclient__python-zhmcclient-56
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_adapter.py:AdapterManager.create_hipersocket" ], "edited_modules": [ "zhmcclient/_adapter.py:AdapterManager" ] }, "file": "zhmcclient/_adapter.py" }, { ...
zhmcclient/python-zhmcclient
01674398fed64b49ebbf94ac49236cee4a02b3d3
Return newly created resources as a resource object not as a URI In the current design, any `create()` methods return the new resource with their URI string. This is inconsistent with the strategy of the zhmcclient project to encapsulate resources as Python objects. **Proposal:** Return a new Python object for...
diff --git a/zhmcclient/_adapter.py b/zhmcclient/_adapter.py index cf76ac0..615ddc9 100644 --- a/zhmcclient/_adapter.py +++ b/zhmcclient/_adapter.py @@ -145,7 +145,9 @@ class AdapterManager(BaseManager): Returns: - string: The resource URI of the new adapter. + Adapter: The resource objec...
zhmcclient__python-zhmcclient-581
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zhmcclient/_console.py:Console.get_audit_log", "zhmcclient/_console.py:Console.get_security_log" ], "edited_modules": [ "zhmcclient/_console.py:Console" ] }, "f...
zhmcclient/python-zhmcclient
c6acd8d98a7cdf7bc38229738e7a5b8db8857147
Console.get_audit_log() and get_security_log() use POST instead of GET ### Actual behavior The use of `Console.get_audit_log()` results in HTTP error 405,0: "Although the resource exists, the specified method does not. [POST /api/console/operations/get-audit-log]". Same for `get_security_log()`. ### Expected beh...
diff --git a/docs/changes.rst b/docs/changes.rst index f0f0859..9e10150 100644 --- a/docs/changes.rst +++ b/docs/changes.rst @@ -51,6 +51,9 @@ Released: not yet because the dependency management did not work with our minimum package versions. +* Fixed use of incorrect HTTP method in `Console.get_audit_log()` an...
zhmcclient__python-zhmcclient-65
[ { "changes": { "added_entities": [ "zhmcclient/_nic.py:NicManager.nic_object" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "zhmcclient/_nic.py:NicManager" ] }, "file": "zhmcclient/_nic.py" }, { "changes": { "adde...
zhmcclient/python-zhmcclient
2ae2e52fa2f8120e85afb119508c818f653f72cd
get_connected_vnics() returns NICs as URIs `VirtualSwitch.get_connected_vnics()` returns the NICs that are connected to the virtual switch. The current design returns these NICs with their URIs. This is inconsistent to other list functions that return resources as their corresponding Python object (`Nic` in this case)...
diff --git a/zhmcclient/_nic.py b/zhmcclient/_nic.py index 10b65a7..c59be21 100644 --- a/zhmcclient/_nic.py +++ b/zhmcclient/_nic.py @@ -124,6 +124,38 @@ class NicManager(BaseManager): props.update(result) return Nic(self, props['element-uri'], props) + def nic_object(self, nic_id): + """ ...
zhs007__trdb2py-28
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "trdb2py/__init__.py" }, { "changes": { "added_entities": [ "trdb2py/pdutils.py:mergePNLEx", "trdb2py/pdutils.py:countTradingDays...
zhs007/trdb2py
1262ef34ea1015bfa5285c3749d13ceada54423b
需要能本地计算最大回撤、回报率等 需要能本地计算最大回撤、回报率等
diff --git a/VERSION b/VERSION index eac0a14..3788c77 100644 --- a/VERSION +++ b/VERSION @@ -1,1 +1,1 @@ -v0.2.1 \ No newline at end of file +v0.2.6 \ No newline at end of file diff --git a/protos/trading2.proto b/protos/trading2.proto index ce86e52..377da35 100644 --- a/protos/trading2.proto +++ b/protos/trading2.prot...
zimeon__ocfl-py-124
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.validate", "ocfl/inventory_validator.py:InventoryValidator.validate_manifest" ], "edited_modules": [ "ocfl/inventory_validator....
zimeon/ocfl-py
74e6f2f0ed964802ca77875ee275c2cf83844853
Improve error reporting for the case of bad digestAlgorithm See https://github.com/OCFL/fixtures/pull/85 Use of `E039` should probably be another `E025` error. Want to tidy up all sorts of confusing errors caused because validator rejects `md5` and then carries on with `sha512` as the default for other checks: ...
diff --git a/docs/demo_build_v1_0_spec_examples.md b/docs/demo_build_v1_0_spec_examples.md index 23e4475..44e6f86 100644 --- a/docs/demo_build_v1_0_spec_examples.md +++ b/docs/demo_build_v1_0_spec_examples.md @@ -100,7 +100,7 @@ This is inventory should match the example with 3 versions in <https://ocfl.io/1 "type":...
zimeon__ocfl-py-54
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.validate" ], "edited_modules": [ "ocfl/inventory_validator.py:InventoryValidator" ] }, "file": "ocfl/inventory_validator....
zimeon/ocfl-py
2c11ca2c8df09bd33eb18f4fc3de1b879826526b
Fix validation error for forward slash in `contentDirectory` From https://github.com/OCFL/fixtures/pull/82 the error for this should be `E017` instead of `E018`
diff --git a/ocfl/data/validation-errors.json b/ocfl/data/validation-errors.json index 1f53481..b3b07ff 100644 --- a/ocfl/data/validation-errors.json +++ b/ocfl/data/validation-errors.json @@ -86,9 +86,16 @@ "en": "OCFL Object version directory %s includes an illegal file (%s)" } }, + "E017": { + "p...
zimeon__ocfl-py-60
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.validate_manifest", "ocfl/inventory_validator.py:InventoryValidator.check_content_path" ], "edited_modules": [ "ocfl/inventory_...
zimeon/ocfl-py
b7ae64de3cc9388bb8b7b606e50aae05cde3c412
Correctly handle validation with multiple entries for a given digest in `manifest` See error case https://github.com/OCFL/fixtures/pull/78
diff --git a/ocfl/data/validation-errors.json b/ocfl/data/validation-errors.json index 56eed29..64f9dbf 100644 --- a/ocfl/data/validation-errors.json +++ b/ocfl/data/validation-errors.json @@ -513,7 +513,13 @@ "en": "OCFL Object %s inventory manifest content path %s must not begin or end with /." } }, -...
zimeon__ocfl-py-62
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.validate_state_block" ], "edited_modules": [ "ocfl/inventory_validator.py:InventoryValidator" ] }, "file": "ocfl/inventor...
zimeon/ocfl-py
0c7d93fe38bb3b58a9c54e7610913379b0631a51
Add check for non-unique logical paths See https://github.com/OCFL/fixtures/pull/65 which currently gets incorrectly reported as valid
diff --git a/ocfl/data/validation-errors.json b/ocfl/data/validation-errors.json index 64f9dbf..b2e50fd 100644 --- a/ocfl/data/validation-errors.json +++ b/ocfl/data/validation-errors.json @@ -483,7 +483,13 @@ "en": "OCFL Object %s inventory %s version block has message key with value that isn't a string" ...
zimeon__ocfl-py-66
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.__init__", "ocfl/inventory_validator.py:InventoryValidator.validate" ], "edited_modules": [ "ocfl/inventory_validator.py:Invent...
zimeon/ocfl-py
e5db6c0099d125bc46f1aa01366b94b5d244afe9
Catch inconsistent id error See https://github.com/OCFL/fixtures/pull/87 in which the `id` in `v1` does not match the `id` in the root/`v2` inventory. My validator fails to report this error: ``` (py38) simeon@RottenApple fixtures> ../ocfl-validate.py 1.0/bad-objects/E037_inconsistent_id INFO:ocfl.object:OCFL obj...
diff --git a/fixtures b/fixtures index db7d333..9a9d868 160000 --- a/fixtures +++ b/fixtures @@ -1,1 +1,1 @@ -Subproject commit db7d3338fef71be3328510d32d768a2746eb0e1f +Subproject commit 9a9d86802f853de56a4b7925adcceccabee390ee diff --git a/ocfl/data/validation-errors.json b/ocfl/data/validation-errors.json index 210f...
zimeon__ocfl-py-72
[ { "changes": { "added_entities": [ "ocfl/inventory_validator.py:InventoryValidator.compare_states_for_version" ], "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:get_file_map", "ocfl/inventory_validator.py:InventoryValidator.validate_as_pr...
zimeon/ocfl-py
008828b7a089aea1b43b87ffeb42d3254faee1ed
Detect E066 for fixture E066_E092_old_manifest_digest_incorrect See https://github.com/OCFL/fixtures/pull/71
diff --git a/ocfl/data/validation-errors.json b/ocfl/data/validation-errors.json index 2c6f570..28f5fea 100644 --- a/ocfl/data/validation-errors.json +++ b/ocfl/data/validation-errors.json @@ -415,17 +415,29 @@ } }, "E066b": { - "params": ["version_dir" , "prior_head", "where"], + "params": ["version" ,...
zimeon__ocfl-py-77
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_validator.py:InventoryValidator.validate" ], "edited_modules": [ "ocfl/inventory_validator.py:InventoryValidator" ] }, "file": "ocfl/inventory_validator....
zimeon/ocfl-py
7a5ef5e75cb86fec6dd8e87b57949fd755931470
URN Object IDs flagged as validation warning OCFL objects with an `id` such as: "URN-3:HUL.DRS.OBJECT:100775205", are flagged as validation warnings. I believe these should be valid.. as URNs are valid URIs and the above URN-3 scheme is a valid URN. See: https://www.iana.org/assignments/urn-informal/urn-3
diff --git a/CHANGES.md b/CHANGES.md index 7be9540..b6f1827 100644 --- a/CHANGES.md +++ b/CHANGES.md @@ -5,6 +5,7 @@ * Additional validation improvements: * Checks between version state in different version inventories * Check to see is extra directories look like version directories + * Fix URI scheme ...
zimeon__ocfl-py-94
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "ocfl-validate.py" }, { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "ocfl/inventory_vali...
zimeon/ocfl-py
aa078262eff7f19ee33e287342e9875fba049b69
Fix handling of spec version in standalone inventory check To replicate example: ``` (py38) simeon@RottenApple ocfl-py> ./ocfl-validate.py extra_fixtures/1.1/good-objects/empty_fixity INFO:ocfl.object:OCFL object at extra_fixtures/1.1/good-objects/empty_fixity is VALID (py38) simeon@RottenApple ocfl-py> ./ocfl-vali...
diff --git a/ocfl-validate.py b/ocfl-validate.py index 30e1d9c..f5653ec 100755 --- a/ocfl-validate.py +++ b/ocfl-validate.py @@ -61,7 +61,8 @@ for path in args.path: obj = ocfl.Object(lax_digests=args.lax_digests) if obj.validate_inventory(path, show_warnings=show_wa...
zincware__ZnTrack-267
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zntrack/core/base.py:get_auto_init_signature", "zntrack/core/base.py:LoadViaGetItem.__matmul__", "zntrack/core/base.py:Node.__init__", "zntrack/core/base.py:Node.__matmul__", ...
zincware/ZnTrack
b955e06d7d5c78a26a3d34cddb4f56c2d630845d
Can not inherit from Node Something like the following currently does not work, ```py class Base(Node) deps = zn.deps() ... class Method1(Base) def run(self): ... ```
diff --git a/examples/docs/02_PassingClasses.ipynb b/examples/docs/02_PassingClasses.ipynb index 868e419..5555ac2 100644 --- a/examples/docs/02_PassingClasses.ipynb +++ b/examples/docs/02_PassingClasses.ipynb @@ -54,41 +54,147 @@ }, { "cell_type": "markdown", - "id": "3d4248c9-df8d-477f-bef4-fee69324ec60", ...
zincware__ZnTrack-271
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "zntrack/zn/plots.py:plots.save" ], "edited_modules": [ "zntrack/zn/plots.py:plots" ] }, "file": "zntrack/zn/plots.py" } ]
zincware/ZnTrack
5e3fdff8b4c60831910efd12a37c1d00d2b2284e
zn.plots: set index.name automatically if not set Raise error if dependency has no outputs duplicate of #137 zn.plots: set index.name automatically if not set
diff --git a/zntrack/zn/plots.py b/zntrack/zn/plots.py index f65dfac..32090a7 100644 --- a/zntrack/zn/plots.py +++ b/zntrack/zn/plots.py @@ -30,10 +30,7 @@ class plots(ZnTrackOption): ) if value.index.name is None: - raise ValueError( - "pd.DataFrame must have an index ...
znicholls__CMIP6-json-data-citation-generator-10
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "CMIP6_json_data_citation_generator/__init__.py:jsonGenerator.write_json_to_file" ], "edited_modules": [ "CMIP6_json_data_citation_generator/__init__.py:jsonGenerator" ] }, ...
znicholls/CMIP6-json-data-citation-generator
53d8fe237e012f156e9d11d082d6474674717dc9
Check special character support check the support for 'utf-8' in the json template and the json result? The authors or even their affiliations might be 'utf-8' (non-English). To give you a German example: One of our most common last names is: 'Müller'.
diff --git a/CMIP6_json_data_citation_generator/__init__.py b/CMIP6_json_data_citation_generator/__init__.py index bb6ab69..dceaa2a 100644 --- a/CMIP6_json_data_citation_generator/__init__.py +++ b/CMIP6_json_data_citation_generator/__init__.py @@ -1,5 +1,7 @@ from os import listdir, makedirs, walk from os.path impor...
zooba__deck-13
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "deck.py:get_poker_hand" ], "edited_modules": [ "deck.py:get_poker_hand" ] }, "file": "deck.py" } ]
zooba/deck
c8ace02770146b674eaeb184a5ebebed36cd2edd
Ace to Five straight/straight flush are not handled in get_poker_hand Low-ace straight/straight flush aren't found as the sort assumes aces-high. PR on way to add tests & support.
diff --git a/deck.py b/deck.py index dc7b3a5..ab7193c 100644 --- a/deck.py +++ b/deck.py @@ -9,7 +9,6 @@ import itertools import random import sys - __all__ = [ "Card", "Deck", @@ -22,7 +21,6 @@ __all__ = [ "Value", ] - _SUIT_SORT_ORDER = { # Handle suit-less comparisons gracefully (as high...
zooniverse__panoptes-python-client-207
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "panoptes_client/panoptes.py:LinkResolver.__setattr__" ], "edited_modules": [ "panoptes_client/panoptes.py:LinkResolver" ] }, "file": "panoptes_client/panoptes.py" } ]
zooniverse/panoptes-python-client
a6f91519326e3be7e974b88ce4f8805c5db9a0e4
Cannot create and save new subject set since 1.1 This [script](https://github.com/miclaraia/muon_analysis/blob/master/muon/scripts/test_panoptes_connection.py) illustrates the problem. The script fails on `subject_set.save()`. Mimics the instructions in the tutorial detailed in the [docs](https://panoptes-python-client...
diff --git a/panoptes_client/panoptes.py b/panoptes_client/panoptes.py index 3f59a9b..463751c 100644 --- a/panoptes_client/panoptes.py +++ b/panoptes_client/panoptes.py @@ -935,7 +935,7 @@ class LinkResolver(object): def __setattr__(self, name, value): reserved_names = ('raw', 'parent') - if name...
zooniverse__panoptes-python-client-55
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "panoptes_client/project.py:Project.find" ], "edited_modules": [ "panoptes_client/project.py:Project" ] }, "file": "panoptes_client/project.py" } ]
zooniverse/panoptes-python-client
6be958cc842488e5410814910febd6e71b14d7b0
Raise something better than StopIteration in .find() when nothing is found https://github.com/zooniverse/panoptes-python-client/blob/67e11e16cd91689e62939a6ba54ff7769259a525/panoptes_client/panoptes.py#L428
diff --git a/panoptes_client/project.py b/panoptes_client/project.py index fa67fd1..807d3b7 100644 --- a/panoptes_client/project.py +++ b/panoptes_client/project.py @@ -30,7 +30,12 @@ class Project(PanoptesObject): def find(cls, id='', slug=None): if not id and not slug: return None - ...
zopefoundation__AccessControl-90
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": null, "edited_modules": null }, "file": "src/AccessControl/ZopeGuards.py" } ]
zopefoundation/AccessControl
099c03fb5bcb7e3cf8e9f3f959a1a30508cd5422
PY3: "ZopeGuards" forgets to allow iteration over the result of "dict.{keys,values,items}" Under Python 3, the `next`s in the following code all result in an `AccessControl.unauthorized.Unauthorized: You are not allowed to access 'a particular tuple' in this context`: ``` from AccessControl.ZopeGuards import SafeIter...
diff --git a/CHANGES.rst b/CHANGES.rst index 8dcf866..874cf62 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -6,7 +6,8 @@ For changes before version 3.0, see ``HISTORY.rst``. 4.1 (unreleased) ---------------- -- Nothing changed yet. +- PY3: allow iteration over the result of ``dict.{keys,values,items}`` + (`#89 <ht...
zopefoundation__Acquisition-10
[ { "changes": { "added_entities": [ "src/Acquisition/__init__.py:_reraise", "src/Acquisition/__init__.py:_make_wrapper_subclass_if_needed" ], "added_modules": [ "src/Acquisition/__init__.py:_reraise", "src/Acquisition/__init__.py:_make_wrapper_subclass_if_needed"...
zopefoundation/Acquisition
6f20ea96fff40814882da580844949ea97f6c4ba
Pure-Python Wrapper objects break `object.__getattribute__` in methods of the wrapped object Certain "base" classes make direct use of `object.__getattribute__` in their method implementations. (i.e., *outside* of their own `__getattribute__` implementation). They may do this for performance reasons, or to simplify the...
diff --git a/CHANGES.rst b/CHANGES.rst index 3e617c3..0b44a8b 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,7 +4,15 @@ Changelog 4.2.2 (unreleased) ------------------ -- TBD +- Make the pure-Python Acquirer objects cooperatively use the + superclass ``__getattribute__`` method, like the C implementation. + See...
zopefoundation__BTrees-141
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "BTrees/_datatypes.py:_AbstractNativeDataType.__call__" ], "edited_modules": [ "BTrees/_datatypes.py:_AbstractNativeDataType" ] }, "file": "BTrees/_datatypes.py" } ]
zopefoundation/BTrees
65d239521e4d488d2e6c477e4bdece6fa3061ebe
`key in btree` should ignore OverflowError Currently, `key in btree` ignores TypeError, so this all works: ```pycon >>> import BTrees >>> bt = BTrees.family32.II.BTree() >>> 'abc' in bt False >>> bt.get('abc') is None True ``` But if the key is outside the range allowed, it fails: ```pycon >>> x = 2 ** 64 ...
diff --git a/BTrees/BTreeModuleTemplate.c b/BTrees/BTreeModuleTemplate.c index ee7aef1..f2ee248 100644 --- a/BTrees/BTreeModuleTemplate.c +++ b/BTrees/BTreeModuleTemplate.c @@ -82,9 +82,11 @@ longlong_handle_overflow(PY_LONG_LONG result, int overflow) { if (overflow) { - /* Python 3 tends to have an e...
zopefoundation__BTrees-163
[ { "changes": { "added_entities": null, "added_modules": [ "src/BTrees/_datatypes.py:_HasDefaultComparison" ], "edited_entities": [ "src/BTrees/_datatypes.py:O._check_default_comparison", "src/BTrees/_datatypes.py:O.__call__" ], "edited_modules": [ ...
zopefoundation/BTrees
02bcfdea1218b11aadba706bd8d4eb14de40f301
Python 2: OxBTrees allow types as keys; Python 3 does not Consider: ```python class Old: pass class New(object): pass from BTrees import family64 bt = family64.OO.BTree() ``` On Python 3, both `Old` and `New`, which are types, cannot go in the tree because they have default comparison: ```pycon ...
diff --git a/CHANGES.rst b/CHANGES.rst index 9172eeb..ae5ec83 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -5,6 +5,13 @@ 4.8.0 (unreleased) ================== +- Make Python 2 forbid the use of type objects as keys (unless a + custom metaclass is used that implements comparison as required by + BTrees.) On Pytho...
zopefoundation__BTrees-43
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "BTrees/_base.py:_no_default_comparison", "BTrees/_base.py:_Tree.__contains__" ], "edited_modules": [ "BTrees/_base.py:_no_default_comparison", "BTrees/_base.py:_Tree"...
zopefoundation/BTrees
be6e6ea7fed82058dc80874eea4813d73df06f3c
BTree.get(object()) raises TypeError on CPython, returns default on PyPy I ran into an implementation difference between the C version and the Python versions. Here's PyPy: ```python Python 2.7.10 (7e8df3df9641, Jun 14 2016, 13:30:54) [PyPy 5.3.1 with GCC 4.2.1 Compatible Apple LLVM 5.1 (clang-503.0.40)] on darwi...
diff --git a/BTrees/BTreeTemplate.c b/BTrees/BTreeTemplate.c index 42d2880..ce77853 100644 --- a/BTrees/BTreeTemplate.c +++ b/BTrees/BTreeTemplate.c @@ -219,6 +219,8 @@ BTree_check(BTree *self) return result; } +#define _BGET_REPLACE_TYPE_ERROR 1 +#define _BGET_ALLOW_TYPE_ERROR 0 /* ** _BTree_get ** @@ -229,...
zopefoundation__BTrees-56
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "BTrees/_base.py:_BucketBase._search" ], "edited_modules": [ "BTrees/_base.py:_BucketBase" ] }, "file": "BTrees/_base.py" } ]
zopefoundation/BTrees
1fb38674c67b084b4c0453a3d5cefb79eca967af
C/Py difference: keys that are the same object The C implementation does a comparison [by first checking whether the two keys are the same pointer](https://github.com/python/cpython/blob/2.7/Objects/object.c#L997); the Python implementation just goes [right to the `==` operator](https://github.com/zopefoundation/BTrees...
diff --git a/BTrees/_base.py b/BTrees/_base.py index 3158d91..bef710a 100644 --- a/BTrees/_base.py +++ b/BTrees/_base.py @@ -111,7 +111,7 @@ class _BucketBase(_Base): while low < high: i = (low + high) // 2 k = keys[i] - if k == key: + if k is key or k == key: ...
zopefoundation__DateTime-37
[ { "changes": { "added_entities": [ "src/DateTime/DateTime.py:DateTime.__format__" ], "added_modules": null, "edited_entities": null, "edited_modules": [ "src/DateTime/DateTime.py:DateTime" ] }, "file": "src/DateTime/DateTime.py" } ]
zopefoundation/DateTime
3fc0626e05f11e899cb60d31177d531b29e53368
supporting fstring formatting It would be great if DateTime could support the new fstring formatting like datetime already does: ``` import datetime, DateTime for now in (datetime.datetime.now(), DateTime.DateTime()): try: print(type(now), f'{now = :%-d.%-m.%Y %H:%M}') except TypeError as e: ...
diff --git a/CHANGES.rst b/CHANGES.rst index a161db6..1811e84 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,7 +4,8 @@ Changelog 4.5 (unreleased) ---------------- -- Nothing changed yet. +- Add ``__format__`` method for DateTime objects + (`#35 <https://github.com/zopefoundation/DateTime/issues/35>`_) 4.4 (...
zopefoundation__DateTime-42
[ { "changes": { "added_entities": null, "added_modules": null, "edited_entities": [ "src/DateTime/DateTime.py:DateTime._parse_args", "src/DateTime/DateTime.py:DateTime.__add__" ], "edited_modules": [ "src/DateTime/DateTime.py:DateTime" ] }, "fil...
zopefoundation/DateTime
09b3d6355b6b44d93922e995b0098dbed22f75ef
tests fail after 2038-01-10 ## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE) ### What I did: run tests on 2038-01-10 on openSUSE, I do ```bash osc co openSUSE:Factory/python-DateTime && cd $_ osc build --vm-type=kvm --noservice --clean --build-opt=--vm-custom-opt="-rtc base=2038-01-10T00:00:00" --alternative-p...
diff --git a/CHANGES.rst b/CHANGES.rst index b1a8f10..68f43b1 100644 --- a/CHANGES.rst +++ b/CHANGES.rst @@ -4,12 +4,15 @@ Changelog 4.7 (unreleased) ---------------- +- Fix rounding problem with `DateTime` addition beyond the year 2038 + (`#41 <https://github.com/zopefoundation/DateTime/issues/41>`_) + 4.6 (20...