instance_id stringlengths 10 57 | file_changes listlengths 1 15 | repo stringlengths 7 53 | base_commit stringlengths 40 40 | problem_statement stringlengths 11 52.5k | patch stringlengths 251 7.06M |
|---|---|---|---|---|---|
zopefoundation__zope.interface-191 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/interface.py:InterfaceClass.queryTaggedValue",
"src/zope/interface/interface.py:InterfaceClass.getTaggedValueTags",
"src/zope/interface/interface.py:_wire"
],
... | zopefoundation/zope.interface | d0c6a5967af074b1a7d60a1bb20d9337263b9571 | Interface.get/queryTaggedValue should respect __iro__, not just __bases__
Consider this inheritance tree:
```python
O = Interface
class F(O):
taggedValue('tag', 'F')
tag = Attribute('F')
class E(O):
taggedValue('tag', 'E')
tag =... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6f3eabc..44bb335 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,16 +5,6 @@
5.0.0 (unreleased)
==================
-- Adopt Python's standard `C3 resolution order
- <https://www.python.org/download/releases/2.3/mro/>`_ for interface
- linearization, with tweaks to supp... |
zopefoundation__zope.interface-195 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/zope/interface/common/collections.py:IMapping",
"src/zope/interface/common/collections.py:IMutableMapping"
]
},
"file": "src/zope/interface/common... | zopefoundation/zope.interface | 3a50f2e88781e90f4d8133fdb2a3b522fc047ade | Inconsistent RO for InterfaceClass
Noticed while working on https://github.com/zopefoundation/zope.schema/issues/80. It's an easy fix. | diff --git a/.travis.yml b/.travis.yml
index 4f47445..cb9713a 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,6 +2,7 @@ language: python
env:
global:
+ ZOPE_INTERFACE_STRICT_IRO: 1
TWINE_USERNAME: zope.wheelbuilder
TWINE_PASSWORD:
secure: "AyR5QxUuZKdmywiepdBG0r8hgFQfaEf2hTxOg/HiXisVNcs1sUPje... |
zopefoundation__zope.interface-198 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:_ImmutableDeclaration.extends"
],
"edited_modules": [
"src/zope/interface/declarations.py:_ImmutableDeclaration"
]
},
"file": "src/zo... | zopefoundation/zope.interface | 1b83ad47e400358dc27e28d1dea013d44b394bde | Regression: Objects with no declared interfaces used to implement Interface
In 5.0.x, the `_empty` `_ImmutableDeclaration` object does not include `Interface`, whereas in 4.7 `_empty` did. This breaks looking up adapter registrations for `Interface` if the provided object does not otherwise implement any interfaces. Th... | diff --git a/CHANGES.rst b/CHANGES.rst
index 961bf72..d6965cb 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,12 @@
5.0.2 (unreleased)
==================
-- Nothing changed yet.
+- Ensure that objects that implement no interfaces (such as direct
+ subclasses of ``object``) still include ``Interface`` itself ... |
zopefoundation__zope.interface-201 | [
{
"changes": {
"added_entities": [
"benchmarks/micro.py:HasConformReturnNone.__conform__",
"benchmarks/micro.py:HasConformReturnObject.__conform__",
"benchmarks/micro.py:bench_iface_call_no_conform_no_alternate_not_provided",
"benchmarks/micro.py:bench_iface_call_no_conform... | zopefoundation/zope.interface | abf12ada0a5806f233a426ae6fc93120da2ba598 | `providedBy()` swallows all exceptions accessing `ob.__providedBy__`
And then has a fallback that ignores it. This makes it very hard to debug issues with descriptors, including issues that result in inconsistent IROs. The reasons it does this are unknown, but may have to do with (security) proxies and/or ease of C imp... | diff --git a/CHANGES.rst b/CHANGES.rst
index 7075008..bf8ce26 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,30 @@
Changes
=========
-5.0.3 (unreleased)
-==================
-
-- Nothing changed yet.
+5.1.0 (unreleased)
+==================
+
+- Remove all bare ``except:`` statements. Previously, when access... |
zopefoundation__zope.interface-202 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null... | zopefoundation/zope.interface | 6c2f71487eed46896647edc9dc770f1fd5da823b | Optimized version of InterfaceBase doesn't use interface's __adapt__
In https://bugs.launchpad.net/zope.interface/+bug/98488, Ben Artin reported:
> According to zope.interface documentation, the `__call__` of an interface should use `__adapt__` in the interface to attempt to adapt the object. This is not so with the o... | diff --git a/CHANGES.rst b/CHANGES.rst
index bf8ce26..70f85e9 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -27,6 +27,23 @@
See `issue 200 <https://github.com/zopefoundation/zope.interface/issues/200>`_.
+- Require that the second argument (*bases*) to ``InterfaceClass`` is
+ a tuple. This only matters when dir... |
zopefoundation__zope.interface-205 | [
{
"changes": {
"added_entities": [
"src/zope/interface/declarations.py:_ImmutableDeclaration._v_attrs"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/zope/interface/declarations.py:_ImmutableDeclaration"
]
},
"file": "src/z... | zopefoundation/zope.interface | a404e5fed4766625b564de558942dd4efd979e89 | ImmutableDeclaration: Allows mutable _v_attrs
Some user code likes to assign to `_v_attrs` and/or write into the dictionary to piggyback on caching. Since ImmutableDeclaration provides no way to clear `_v_attrs` (it assumes it stays None), this can lead to incorrect results.
This is not a regression in 5.0 but a pr... | diff --git a/CHANGES.rst b/CHANGES.rst
index 70f85e9..b86e14d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -45,6 +45,12 @@
See `issue 3 <https://github.com/zopefoundation/zope.interface/issues/3>`_.
+- Make the internal singleton object returned by APIs like
+ ``implementedBy`` and ``directlyProvidedBy`` for o... |
zopefoundation__zope.interface-209 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/interfaces.py:ISpecification.providedBy",
"src/zope/interface/interfaces.py:IInterface.names",
"src/zope/interface/interfaces.py:IInterface.namesAndDescriptions",
... | zopefoundation/zope.interface | 10a951f9db32c3e3a29fef4e8b72e354b0c80047 | verifyClass(IAdapterRegistry, AdapterRegistry)...
```
from zope.interface.adapter import AdapterRegistry, IAdapterRegistry
verifyClass(IAdapterRegistry, AdapterRegistry)
...
MultipleInvalid: The object <class 'zope.interface.adapter.AdapterRegistry'> has failed to implement interface <InterfaceClass zope.interfac... | diff --git a/CHANGES.rst b/CHANGES.rst
index 7f8a957..a22876d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,12 @@
5.1.1 (unreleased)
==================
-- Nothing changed yet.
+- Fix the method definitions of ``IAdapterRegistry.subscribe``,
+ ``subscriptions`` and ``subscribers``. Previously, they all were... |
zopefoundation__zope.interface-228 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/conf.py"
},
{
"changes": {
"added_entities": [
"src/zope/interface/adapter.py:BaseAdapterRegistry._addValueToLeaf",
"src/zo... | zopefoundation/zope.interface | c28c205c91e73d3ca5e195bb0392d10046e13be0 | BaseAdapterRegistry hardcodes non-Persistent data structures; can be painful in very large sites. Add hooks?
Problem Description
===============
`BaseAdapterRegistry` has a few attributes that contain its data, most importantly `_subscribers` and `_adapters`:
https://github.com/zopefoundation/zope.interface/blob... | diff --git a/CHANGES.rst b/CHANGES.rst
index 65bec4e..ff3254c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,11 +2,27 @@
Changes
=========
-5.2.1 (unreleased)
-==================
-
-- Nothing changed yet.
-
+5.3.0 (unreleased)
+==================
+
+- Allow subclasses of ``BaseAdapterRegistry`` (including
+ ``A... |
zopefoundation__zope.interface-231 | [
{
"changes": {
"added_entities": [
"src/zope/interface/adapter.py:BaseAdapterRegistry._find_leaf",
"src/zope/interface/adapter.py:BaseAdapterRegistry.subscribed"
],
"added_modules": null,
"edited_entities": [
"src/zope/interface/adapter.py:BaseAdapterRegistry.regi... | zopefoundation/zope.interface | dd69666aae99afe0d47b3af81149fbd7e97f59fe | Add AdapterRegistry.subscribed()
This would be analogous to `AdapterRegistry.registered()`.
My particular use case for this for consistency checking and error correction. When you call `Components.registerUtility()` , the utility is supposed to wind up in three places:
- Components._utility_registrations
- Compo... | diff --git a/CHANGES.rst b/CHANGES.rst
index ff3254c..94f07b1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -24,6 +24,18 @@
to fix the reference counting issue mentioned above, as well as to
update the data structures when custom data types have changed.
+- Add the interface method ``IAdapterRegistry.subscribed... |
zopefoundation__zope.interface-234 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:Provides.__repr__"
],
"edited_modules": [
"src/zope/interface/declarations.py:Provides"
]
},
"file": "src/zope/interface/declarations... | zopefoundation/zope.interface | cfe4075488f3b18a46d406e5cac7be012b7a9404 | `directlyProvides` doesn't log changed resolution orders
When debugging https://github.com/zopefoundation/zc.resourcelibrary/issues/6, we discovered a resolution order that changed between the legacy and C3 orderings. This resolution order was created by `directlyProvides()`, not statically. For whatever reason, `direc... | diff --git a/CHANGES.rst b/CHANGES.rst
index c791f50..02d72c2 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,10 @@
5.3.0 (unreleased)
==================
+- Improve the repr of ``zope.interface.Provides`` to remove ambiguity
+ about what is being provided. This is especially helpful diagnosing
+ IRO issues.... |
zopefoundation__zope.interface-237 | [
{
"changes": {
"added_entities": [
"src/zope/interface/declarations.py:Declaration._argument_names_for_repr"
],
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:Implements.__repr__",
"src/zope/interface/declarations.py:Provides.__rep... | zopefoundation/zope.interface | e6d3805c6e155a89a34d89601477881aec9b7df1 | Update __repr__ and __str__ for (at least) Provides and InterfaceClass?
(Moved from https://github.com/zopefoundation/zope.interface/pull/234#discussion_r596750717)
Given `spec = Provides(AClass, IFoo, IBar)`, the repr will be something like
```
<zope.interface.Provides for instances of <class 'some.module.AClas... | diff --git a/CHANGES.rst b/CHANGES.rst
index 1cbff80..600fbb8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,6 +2,16 @@
Changes
=========
+5.4.0 (unreleased)
+==================
+
+- Update the ``repr()`` and ``str()`` of various objects to be shorter
+ and more informative. In many cases, the ``repr()`` is now... |
zopefoundation__zope.interface-238 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:Declaration.__add__"
],
"edited_modules": [
"src/zope/interface/declarations.py:Declaration"
]
},
"file": "src/zope/interface/declara... | zopefoundation/zope.interface | 4a686fc8d87d398045dc44c1b6a97a2940121800 | Declaration.__add__ easily produces inconsistent RO
Noticed while working on https://github.com/zopefoundation/zope.schema/issues/80.
It simply takes itself as the `__bases__`, and whatever is unique to its second argument it tacked on, ignoring their relative order. If the two arguments partially overlap, this is ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 600fbb8..5b57ddb 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -12,6 +12,14 @@
shown as ``classImplements(list, IMutableSequence, IIterable)``. See
`issue 236 <https://github.com/zopefoundation/zope.interface/issues/236>`_.
+- Make ``Declaration.__add__`` (as in ``im... |
zopefoundation__zope.interface-240 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/interface/declarations.py:ObjectSpecificationDescriptor.__get__"
],
"edited_modules": [
"src/zope/interface/declarations.py:ObjectSpecificationDescriptor"
]
},
... | zopefoundation/zope.interface | 4a686fc8d87d398045dc44c1b6a97a2940121800 | Python/C discrepancy: Python can raise RecursionError if __setattr__ and __getattr__ use providedBy()
(Found while working on `collective/contentratings`, which [has exactly this anti-pattern](https://github.com/collective/contentratings/blob/d2ed3de58cc6bf1576e40890d28bee224f96e363/contentratings/category.py#L210-L237... | diff --git a/CHANGES.rst b/CHANGES.rst
index 600fbb8..0cfdab7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,13 @@
5.4.0 (unreleased)
==================
+- Make the C implementation of the ``__providedBy__`` descriptor stop
+ ignoring all errors raised when accessing the instance's
+ ``__provides__``. Now ... |
zopefoundation__zope.interface-285 | [
{
"changes": {
"added_entities": [
"src/zope/interface/interface.py:InterfaceClass.__or__",
"src/zope/interface/interface.py:InterfaceClass.__ror__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/zope/interface/interface.py:Inter... | zopefoundation/zope.interface | ca76bcb5db018827f406201cfbb063ec7eae3e24 | Consider adding support for `__or__`/`__ror__` to `IntefaceClass`
## FEATURE REQUEST
Currently interfaces created with zope.interface do not support the Python3.10 shorthand notation for union types, it makes sense that this is not supported by default, since subclassing `Interface` creates instances of `Interface... | diff --git a/CHANGES.rst b/CHANGES.rst
index 90e1309..2e2772b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,10 @@
- Add preliminary support for Python 3.13 as of 3.13a3.
+- Add support to use the pipe (``|``) syntax for ``typing.Union``.
+ (`#280 <https://github.com/zopefoundation/zope.interface/issues/28... |
zopefoundation__zope.interface-44 | [
{
"changes": {
"added_entities": [
"src/zope/interface/declarations.py:Implements.named",
"src/zope/interface/declarations.py:Implements.__cmp",
"src/zope/interface/declarations.py:Implements.__hash__",
"src/zope/interface/declarations.py:Implements.__eq__",
"src/zo... | zopefoundation/zope.interface | e79273048b92735fb23fcee7f695a5ed5d72f647 | Make declarations.Implements (and possibly Provides) comparable?
Recently we had the need to do some `IComponents`-like things on some very large persistent data sets. So we started with a subclass of `AdapterRegistry` and made it use BTrees instead of dicts. Everything works fine so long as you stay in the realm of in... | diff --git a/CHANGES.rst b/CHANGES.rst
index 7ac92c4..db52ae5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,10 @@ Changes
4.2.1 (unreleased)
------------------
-- TBD
+- Add the ability to sort the objects returned by ``implementedBy``.
+ This is compatible with the way interface classes sort so they can
+... |
zopefoundation__zope.mkzeoinstance-18 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/mkzeoinstance/__init__.py:ZEOInstanceBuilder.create"
],
"edited_modules": [
"src/zope/mkzeoinstance/__init__.py:ZEOInstanceBuilder"
]
},
"file": "src/zope/mkze... | zopefoundation/zope.mkzeoinstance | 5b8928d4e90dd7c34f12c52c855eaf37ab6b699e | Make parameter `blob_dir` optional when using `create()` api.
The newly implemented parameter `blob_dir` causes a traceback when its missing in `params` for `ZEOInstanceBuilder().create(location, params)`. See https://github.com/plone/plone.recipe.zeoserver/pull/45#issuecomment-1531537732 | diff --git a/CHANGES.rst b/CHANGES.rst
index b134306..bdb624c 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,8 @@ Changelog
5.2 (unreleased)
----------------
-- Nothing changed yet.
+- Optional `blob_dir` parameter.
+ (`#18 <https://github.com/zopefoundation/zope.mkzeoinstance/pull/18>`_)
5.1 (2023-04-... |
zopefoundation__zope.mkzeoinstance-7 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/mkzeoinstance/__init__.py:ZEOInstanceBuilder.run"
],
"edited_modules": [
"src/zope/mkzeoinstance/__init__.py:ZEOInstanceBuilder"
]
},
"file": "src/zope/mkzeoin... | zopefoundation/zope.mkzeoinstance | 7ed33bb183929e5645a71950f5032018acbbda51 | Broken with ZEO 5.1.1: runzeo and zeoctl fails.
While investigating zopefoundation/ZEO#87 I figured out, that the scripts running zeoctl and runzeo are no longer working due to usage of relative imports in ZEO.runzeo and ZEO.zeoctl.
It looks like the clean way is to not call the files as scripts, but execute them as... | diff --git a/CHANGES.rst b/CHANGES.rst
index 607054e..f794d66 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,7 @@ Changelog
4.1 (unreleased)
----------------
-- Nothing changed yet.
+- Fix generated ``runzeo`` and ``zeoctl`` scripts to run with ZEO 5.
4.0 (2017-02-28)
diff --git a/src/zope/mkzeoinstance... |
zopefoundation__zope.password-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/password/zpasswd.py:Application.process",
"src/zope/password/zpasswd.py:parse_args"
],
"edited_modules": [
"src/zope/password/zpasswd.py:Application",
"src/z... | zopefoundation/zope.password | d517a5a165a28336ae51c5e2dabea8a65390e586 | Convert usage of optparse to argparse
optparse is deprecated. | diff --git a/CHANGES.rst b/CHANGES.rst
index c44b413..421388f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -14,6 +14,8 @@
- Fix the ``zpasswd`` console script on Python 3.
+- Update the ``zpasswd`` script to use ``argparse`` instead of ``optparse.``
+
4.2.0 (2016-07-07)
==================
diff --git a/src/zop... |
zopefoundation__zope.password-13 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/password/legacy.py:CryptPasswordManager.encodePassword",
"src/zope/password/legacy.py:CryptPasswordManager.checkPassword",
"src/zope/password/legacy.py:CryptPasswordManager.matc... | zopefoundation/zope.password | f18b5f9371ceb5e7af68c917f2ae9f7de3d91cad | Support reading the format that z3c.bcrypt produces?
Now that we have a bcrypt password manager (and maybe a KDF manager, see #9) it might be nice if we could read the format for those two managers that z3c.bcrypt produces (they have distinct prefixes, just different from the prefixes our existing bcrypt manager uses).... | diff --git a/CHANGES.rst b/CHANGES.rst
index 421388f..1375b4f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,8 +5,13 @@
4.3.0 (unreleased)
==================
-- Added a ``bcrypt``-based password manager (available only if the ``bcrypt``
- library is importable).
+- Added a ``bcrypt``-based password manager (avai... |
zopefoundation__zope.publisher-19 | [
{
"changes": {
"added_entities": [
"src/zope/publisher/base.py:BaseRequest.__bool__"
],
"added_modules": null,
"edited_entities": [
"src/zope/publisher/base.py:BaseRequest.__nonzero__"
],
"edited_modules": [
"src/zope/publisher/base.py:BaseRequest"
... | zopefoundation/zope.publisher | 4021bcdecb998b1b45ca32222eaa1126925de794 | `BaseRequest` needs to define `__bool__` for Python 3
It defines `__nonzero__` to always be True for Python 2, but it doesn't define `__bool__` for Python 3. So it falls back to `__len__` and you get different behaviour (requests seem false when they shouldn't be).
Found testing zc.resourcelibrary with Python 3. htt... | diff --git a/CHANGES.rst b/CHANGES.rst
index 608b131..747afad 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,10 @@ Changes
4.3.2 (unreleased)
------------------
-- Nothing changed yet.
+- Fix instances of ``BaseRequest`` (including ``BrowserRequest``)
+ being unexpectedly ``False`` on Python 3 by defining `... |
zopefoundation__zope.publisher-46 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/publisher/browser.py:BrowserRequest._decode",
"src/zope/publisher/browser.py:BrowserRequest.processInputs"
],
"edited_modules": [
"src/zope/publisher/browser.py:Brow... | zopefoundation/zope.publisher | 8f3e22e76da739a77168298a7708f5a0515537c5 | UnicodeEncodeError: 'latin-1' codec can't encode character '\u0173' in position 9: ordinal not in range(256) on Python 3.7, while parsing POST requests containing non-ASCII field values
BrowserRequest.processInputs() is working on the assumption that cgi.FieldStorage will give it UTF-8 text encoded to Latin-1, as p... | diff --git a/CHANGES.rst b/CHANGES.rst
index b81a3f7..18b01f5 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -10,6 +10,10 @@
- ``FileUpload`` objects now support the ``seekable()`` method on Python 3.
Fixes `issue 44 <https://github.com/zopefoundation/zope.publisher/issue/44>`_.
+- Character set handling was rathe... |
zopefoundation__zope.publisher-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/publisher/browser.py:FileUpload.__init__"
],
"edited_modules": [
"src/zope/publisher/browser.py:FileUpload"
]
},
"file": "src/zope/publisher/browser.py"
}
] | zopefoundation/zope.publisher | 02e5f31a8e1950c5bd24f5a60d77025dd06bb330 | AttributeError: 'FileUpload' object has no attribute 'seekable'
If you pass self.request['file_field'] to zipfile.ZipFile() on Python 3.7, you will get this error:
Traceback (most recent call last):
...
File "/usr/lib/python3.7/zipfile.py", line 1428, in read
with self.open(name, "r", pw... | diff --git a/CHANGES.rst b/CHANGES.rst
index 26bc3d8..b81a3f7 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@
- Drop support for Python 3.4.
+- ``FileUpload`` objects now support the ``seekable()`` method on Python 3.
+ Fixes `issue 44 <https://github.com/zopefoundation/zope.publisher/issue/44>`_.
+
... |
zopefoundation__zope.publisher-9 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/publisher/http.py:HTTPResponse.getHeaders"
],
"edited_modules": [
"src/zope/publisher/http.py:HTTPResponse"
]
},
"file": "src/zope/publisher/http.py"
}
] | zopefoundation/zope.publisher | 57a3cee97207ab4a4f05924a07857d007109e17c | Response headers are in random order
`HTTPResponse.getHeaders()` returns a list of headers in dictionary-internal order. This causes problems like https://github.com/zopefoundation/zope.app.publication/issues/3. | diff --git a/src/zope/publisher/http.py b/src/zope/publisher/http.py
index 51ef486..f571f05 100644
--- a/src/zope/publisher/http.py
+++ b/src/zope/publisher/http.py
@@ -721,7 +721,7 @@ class HTTPResponse(BaseResponse):
result.append(
("X-Powered-By", "Zope (www.zope.org), Python (www.python.org)")... |
zopefoundation__zope.ramcache-5 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/ramcache/ram.py:Storage.removeStaleEntries",
"src/zope/ramcache/ram.py:Storage.removeLeastAccessed",
"src/zope/ramcache/ram.py:Storage._clearAccessCounters",
"src/zope/r... | zopefoundation/zope.ramcache | c8a5cc3e393783668826355fe26b7b4ec299304d | Ram cache statistics crash
I've added a @ram.cache() decorator to a function returning a IITreeSet object.
Basically I need to cache some index search resultset in order to speedup the site.
Unfortunately when checking the ram cache statistcs, it fails with the message:
```python
Traceback (innermost last):
Modu... | diff --git a/CHANGES.rst b/CHANGES.rst
index c217aeb..5fcdb64 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -13,6 +13,10 @@
- Test PyPy3 on Travis CI.
+- Stop requiring all values to support pickling in order to get
+ statistics. Instead, return ``False`` for the size if such a value
+ is found. Fixes `issue 1 <... |
zopefoundation__zope.schema-103 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/fieldproperty.py:FieldUpdatedEvent.__init__"
],
"edited_modules": [
"src/zope/schema/fieldproperty.py:FieldUpdatedEvent"
]
},
"file": "src/zope/schema/f... | zopefoundation/zope.schema | 9c65715a58c0cc2adf9b6eeef767d24f0219920a | IFieldUpdatedEvent not correctly implemented by FieldUpdatedEvent.
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
### What I did:
I looked at `IFieldUpdatedEvent` and noticed it declares an `object` attribute. Then I looked at the `FieldUpdatedEvent` implementation and noticed it does not comply and implements an ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 74ecebc..e896fa8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@
- Add support for Python 3.9.
+- Fix FieldUpdateEvent implementation by having an ``object`` attribute as the
+ ``IFieldUpdatedEvent`` interfaces claims there should be.
6.0.0 (2020-03-21)
... |
zopefoundation__zope.schema-105 | [
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:Bool.__init__"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Bool"
]
},
"file": "src/zope/schema/_bootstrapfields.py"
... | zopefoundation/zope.schema | d75391aa52f194191593e4d6452d6464e25188a1 | IField.required attribute is True but must not.
## BUG/PROBLEM REPORT (OR OTHER COMMON ISSUE)
### What I did:
We use `IField` https://github.com/zopefoundation/zope.schema/blob/master/src/zope/schema/interfaces.py#L192 with z3c.form to generate a form (plone.schemaeditor).
### What I expect to happen:
The ... | diff --git a/CHANGES.rst b/CHANGES.rst
index ef003be..7d8dbc8 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,8 +5,8 @@
6.0.2 (unreleased)
==================
-- Nothing changed yet.
-
+- Fix ``IField.required`` to not be required by default.
+ See `issue 104 <https://github.com/zopefoundation/zope.schema/issues/... |
zopefoundation__zope.schema-39 | [
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:Field.__get_property_names_to_compare",
"src/zope/schema/_bootstrapfields.py:Field.__hash__"
],
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field.__eq__"
... | zopefoundation/zope.schema | 919388ca4e26346f1a4463e0fecc8ad2fd9f871b | Fields are not hashable in Python 3
There is a inconsistency that breaks caching schema-fields in Plone with memoize. What do we need to change to make field instances hashable?
Python2:
```
(Pdb++) obj
<zope.schema._bootstrapfields.TextLine object at 0x10984c190>
(Pdb++) hash(obj)
278416409
(Pdb++) obj.__clas... | diff --git a/CHANGES.rst b/CHANGES.rst
index ddf13a4..67b7b56 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,14 @@ Changes
4.5.1 (unreleased)
------------------
-- Nothing changed yet.
+- ``Field`` instances are hashable on Python 3, and use a defined
+ hashing algorithm that matches what equality does on a... |
zopefoundation__zope.schema-44 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"src/zope/schema/interfaces.py:ITokenizedTerm"
]
},
"file": "src/zope/schema/interfaces.py"
},
{
"changes": {
"added_entities": null,
"adde... | zopefoundation/zope.schema | ec25d71f984c16fc521c18f0ee72d219a18c1285 | schema doesn't support unicode in choice keys
In https://bugs.launchpad.net/zope.schema/+bug/615605, Vladislav Vorobiev (mymir.org@gmail.com) reported:
> If I use not asci in the keys get an unicode error.
``` python
class IMainSearch(Interface):
city = Choice( title=_(u"city"), values={u'Köln':u'Кельн', u'Bonn':... | diff --git a/CHANGES.rst b/CHANGES.rst
index 6e845a8..80df698 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -20,6 +20,13 @@ Changes
``max`` values (they must still specify a ``default`` value). See
`issue 9 <https://github.com/zopefoundation/zope.schema/issues/9>`_.
+- ``Choice``, ``SimpleVocabulary`` and ``Si... |
zopefoundation__zope.schema-45 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "docs/conf.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_field.... | zopefoundation/zope.schema | c61de9872ad17fb279641784329266ad371d2366 | Field zope.schema.Object does not check for invariants
In https://bugs.launchpad.net/zope.schema/+bug/567520, @andreypopp reported:
> Field zope.schema.Object does not check invariant during validation. I have attached simple test for that.
and attached a file: https://bugs.launchpad.net/zope.schema/+bug/567520/+att... | diff --git a/CHANGES.rst b/CHANGES.rst
index 80df698..6ab7c79 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,12 @@ Changes
4.5.1 (unreleased)
------------------
+- ``Object`` instances call their schema's ``validateInvariants``
+ method by default to collect errors from functions decorated with
+ ``@invari... |
zopefoundation__zope.schema-46 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"src/zope/schema/_bootstrapfields.py:InvalidIntLiteral"
],
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field.validate",
"src/zope/schema/_bootstrapfields.py:Field._validate",
"src/zope... | zopefoundation/zope.schema | 1696ffef6aa44e530e7095bd41365749634707df | `zope.schema.Object._validate`: missing field information in error reports
In https://bugs.launchpad.net/zope.schema/+bug/620324, Dieter Maurer (dieter@handshake.de) reported:
> Error reports from `zope.schema.Object._validate` for field related errors often lack the information about the affected field. This makes id... | diff --git a/CHANGES.rst b/CHANGES.rst
index de05167..01bb7c1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -42,6 +42,21 @@
<https://github.com/zopefoundation/zope.schema/issues/15>`_ and `PR
6 <https://github.com/zopefoundation/zope.schema/pull/6>`_.
+- All instances of ``ValidationError`` have a ``field`` and... |
zopefoundation__zope.schema-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/schema/__init__.py"
},
{
"changes": {
"added_entities": [
"src/zope/schema/_field.py:Mapping.__init__",
"src/zope/schem... | zopefoundation/zope.schema | f169f305112c3830f1ad84af72449aea64a2d52e | Schema fields don't work with PersistentList and Dict
In https://bugs.launchpad.net/zope.schema/+bug/131112, Damien Genet reported:
> `PersistentList` & `PersistentDict` aren't valid types for `List` & `Dict` schema fields. For instance the following code fails (where `IKLass` is a `zope.schema.List`) :
``` python
cl... | diff --git a/CHANGES.rst b/CHANGES.rst
index 01bb7c1..9f9da33 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -58,6 +58,14 @@
validating invariants. See `issue 16
<https://github.com/zopefoundation/zope.schema/issues/16>`_.
+- Add new fields ``Mapping`` and ``MutableMapping``, corresponding to
+ the collections ... |
zopefoundation__zope.schema-48 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/schema/__init__.py"
},
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:_NotGiven.__repr__"
],
... | zopefoundation/zope.schema | 19c95112eea707be0e40166c59f0702a280a14f0 | "AbstractCollection" should allow to define "value_type" in a derived class
Currently, "AbstractCollection" looks like:
```
class AbstractCollection(MinMaxLen, Iterable)
value_type = None
unique = False
def __init__(self, value_type=None, unique=False, **kw):
super(AbstractCollection, self).__init... | diff --git a/CHANGES.rst b/CHANGES.rst
index 9f9da33..d83b78b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -66,6 +66,17 @@
to the collections ABCs of the same name; ``Tuple`` now extends
``Sequence`` and ``List`` now extends ``MutableSequence``.
+- Add new field ``Collection``, implementing ``ICollection``. Th... |
zopefoundation__zope.schema-50 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/schema/__init__.py"
},
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:Number.fromUnicode"
],
... | zopefoundation/zope.schema | ff8f7293507663e463a01034b506c73ca9af0718 | Add fields/interfaces for the numeric tower
Similar to #11 and its implementation in #47 where we added fields and interfaces for `collections.Sequence`, `collections.MutableSequence`, `collections.Mapping` and`collections.MutableMapping`, I think it makes sense to have fields and interfaces for `numbers.Number`, `numb... | diff --git a/CHANGES.rst b/CHANGES.rst
index 500e178..624d87f 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -87,6 +87,16 @@
subclass, enabling a simpler constructor call. See `issue 23
<https://github.com/zopefoundation/zope.schema/issues/23>`_.
+- Add fields and interfaces representing Python's numeric tower. ... |
zopefoundation__zope.schema-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field.__get_property_names_to_compare",
"src/zope/schema/_bootstrapfields.py:Field.__hash__",
"src/zope/schema/_bootstrapfields.py:Field.__eq__"
... | zopefoundation/zope.schema | b6625652d6bdd0d3c6a6568bd1c9f592a2013ec6 | Should Field objects include their owning `interface` in equality/hashing?
Currently they don't include that, leaving open the possibility that two different Field objects from two different interfaces are equal, which may or may not be the intent.
```pycon
>>> from zope.interface import Interface
>>> from zope.sche... | diff --git a/CHANGES.rst b/CHANGES.rst
index d83b78b..500e178 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -30,6 +30,16 @@
compatibility problem. See `issue 36
<https://github.com/zopefoundation/zope.schema/issues/36>`_.
+- ``Field`` instances are only equal when their ``.interface`` is
+ equal. In practice, ... |
zopefoundation__zope.schema-52 | [
{
"changes": {
"added_entities": [
"src/zope/schema/vocabulary.py:SimpleTerm.__eq__",
"src/zope/schema/vocabulary.py:SimpleTerm.__ne__",
"src/zope/schema/vocabulary.py:SimpleTerm.__hash__",
"src/zope/schema/vocabulary.py:SimpleVocabulary.__eq__",
"src/zope/schema/vo... | zopefoundation/zope.schema | 665e2e73f639d07620f421540100cc29fa3498f7 | Creating vocabularies
There are a few helper methods in SimpleVocabulary that create vocabs for you. None of these appear to allow one to pass through a title to the SimpleTerm objects that are created. I find myself writing a method that allows me to pass in a title and create a simple vocab quite often. It would be ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 624d87f..5eada5d 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -97,6 +97,16 @@
- Make ``Iterable`` and ``Container`` properly implement ``IIterable``
and ``IContainer``, respectively.
+- Make ``SimpleVocabulary.fromItems`` accept triples to allow
+ specifying the titl... |
zopefoundation__zope.schema-59 | [
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:getFields",
"src/zope/schema/_bootstrapfields.py:_ObjectsBeingValidated.__init__",
"src/zope/schema/_bootstrapfields.py:get_schema_validation_errors",
"src/zope/schema/_bootstrapfields.py:get_validation... | zopefoundation/zope.schema | a409cbf2f88a19f9d4fc1bb0b8510634044bcc8c | `getSchemaValidationErrors` is freakily similar to `_validate_fields` used by `Object`
There are two differences:
- `_validate_fields` correctly handles cycles; `gSVE` does not.
- `_validate_fields` returns a dictionary (now); `gSVE` returns a list of tuples.
On first blush, it appears that `gSVE` binds the fiel... | diff --git a/CHANGES.rst b/CHANGES.rst
index 99b9c7c..9d29d73 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -115,6 +115,17 @@
- Make ``SimpleVocabulary`` and ``SimpleTerm`` have value-based
equality and hashing methods.
+- All fields of the schema of an ``Object`` field are bound to the
+ top-level value being v... |
zopefoundation__zope.schema-62 | [
{
"changes": {
"added_entities": [
"src/zope/schema/_bootstrapfields.py:_DocStringHelpers.docstring_to_lines",
"src/zope/schema/_bootstrapfields.py:_DocStringHelpers.make_class_directive",
"src/zope/schema/_bootstrapfields.py:_DocStringHelpers.make_field",
"src/zope/schema/... | zopefoundation/zope.schema | 0a719f2ded189630a0a77e9292a66a3662c6512c | Can `Field.getDoc()` include more information?
There is a lot of information that Field has that's not currently printed by, e.g., `repoze.sphinx.autointerface`, such as the type of acceptable values, whether they are required, the default, and so on. For example, here's what `IField` looks like now:
`` return more information about the properties
+ of the field, such as its required and readonly sta... |
zopefoundation__zope.schema-67 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field._validate"
],
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Field"
]
},
"file": "src/zope/schema/_bootstrapfields.p... | zopefoundation/zope.schema | d7d91931293294952a26aec2f7047fdda50822e0 | Checking constraints should set `field` and `value` for ValidationErrors
Sometimes custom `constraint` functions raise a `ValidationError` subclass instead of returning a boolean, usually because they have a better error message. But if the constraint is a function, it doesn't have access to the field instance, so the ... | diff --git a/CHANGES.rst b/CHANGES.rst
index dd41b9c..4ae52fb 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,10 @@
4.6.2 (unreleased)
==================
-- Nothing changed yet.
+- Fix checking a field's constraint to set the ``field`` and ``value``
+ properties if the constraint raises a ``ValidationError``... |
zopefoundation__zope.schema-68 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Object.__init__",
"src/zope/schema/_bootstrapfields.py:Object._validate"
],
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Objec... | zopefoundation/zope.schema | b6cc7d2cff904129c36e867f369c577d85c1ba2e | Exceptions could use some named attributes
In our validation code using zope.schema fields, we have lots of things that look like this:
```python
try:
field.validate(value)
except WrongContainedType as e:
if e.args and all(isinstance(SchemaNotProvided, v) for v in e.args[0]):
# try to adapt
exc... | diff --git a/.gitignore b/.gitignore
index b90c7ed..a063dff 100644
--- a/.gitignore
+++ b/.gitignore
@@ -6,6 +6,7 @@ eggs
develop-eggs
build
docs/_build
+docs/.doctrees
parts
*.egg-info
.tox
diff --git a/CHANGES.rst b/CHANGES.rst
index f7abd23..ed38933 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,11 +2,23 @@
... |
zopefoundation__zope.schema-72 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field.__init__"
],
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Field"
]
},
"file": "src/zope/schema/_bootstrapfields.py... | zopefoundation/zope.schema | b5964f548c8ecb87b0c8c3b3b1463cd478a05237 | When a field has no description (description=None) initialization fails
The recent changes broke the Plone-biuld (e.g. https://jenkins.plone.org/view/PLIPs/job/plip-py3/707)
```
Traceback (most recent call last):
File "/home/jenkins/workspace/plip-py3/src/plone.supermodel/plone/supermodel/parser.py", line 72, in... | diff --git a/CHANGES.rst b/CHANGES.rst
index edd1fb6..b1687df 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -9,6 +9,8 @@
numeric and bytes fields, as well as ``URI``, ``DottedName``, and
``Id``.
+- Fix passing ``None`` as the description to a field constructor. See
+ `issue 69 <https://github.com/zopefoundatio... |
zopefoundation__zope.schema-75 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"src/zope/schema/_field.py:NativeString",
"src/zope/schema/_field.py:NativeStringLine"
],
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/schema/_field.py"
},
{
"changes":... | zopefoundation/zope.schema | d78c57c3c9ab8608fda1c1213c64d1666db770e2 | Make NativeString[Line] a distinct type
Especially now that we document the implementation class of fields, having NativeString[Line] be simple aliases of either Bytes or Text[Line] is confusing and misleading, because what you see in the documentation is Bytes or Text, but that's not what you need to put in source cod... | diff --git a/CHANGES.rst b/CHANGES.rst
index a861314..01773e1 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,13 @@
Changes
=========
-4.8.1 (unreleased)
+4.9.0 (unreleased)
==================
-- Nothing changed yet.
+- Make ``NativeString`` and ``NativeStringLine`` distinct types that
+ implement the n... |
zopefoundation__zope.schema-77 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Field.getExtraDocLines"
],
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Field"
]
},
"file": "src/zope/schema/_bootstrapf... | zopefoundation/zope.schema | d78c57c3c9ab8608fda1c1213c64d1666db770e2 | `getDoc()` can produce invalid ReST when `value_type` is present
Noticed in zope.configuration:
```pycon
>>> from zope.configuration import config
>>> print(config.IDirectiveInfo['schema'].getDoc())
Directive handler
The dotted name of the directive handler
:Implementation: :class:`zope.configuration.config.D... | diff --git a/CHANGES.rst b/CHANGES.rst
index a861314..d50182e 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@
- Nothing changed yet.
+- Fix ``Field.getDoc()`` when ``value_type`` or ``key_type`` is
+ present. Previously it could produce ReST that generated Sphinx
+ warnings. See `issue 76 <https://git... |
zopefoundation__zope.schema-89 | [
{
"changes": {
"added_entities": null,
"added_modules": [
"src/zope/schema/_bootstrapfields.py:InvalidDecimalLiteral",
"src/zope/schema/_bootstrapfields.py:Decimal"
],
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/schema/_bootstrapfiel... | zopefoundation/zope.schema | ee3aa418d1c9425dccf3fbb210924b77340f04a0 | IDecimal leaves min, max, default attributes with type Number
#49 added number hierarchies. Most types seem to define their min, max, default attributes as their own type. IDecimal and IFloat seem to be exceptions. While implementation differences seem to be tiny, registering adapters against those attributes matters.
... | diff --git a/CHANGES.rst b/CHANGES.rst
index 13cb2af..09c4157 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,6 +5,10 @@
5.0 (unreleased)
================
+- Set ``IDecimal`` attributes ``min``, ``max`` and ``default`` as ``Decimal``
+ type instead of ``Number``.
+ See `issue 88 <https://github.com/zopefoundatio... |
zopefoundation__zope.schema-91 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/schema/_bootstrapfields.py:Text.__init__"
],
"edited_modules": [
"src/zope/schema/_bootstrapfields.py:Text"
]
},
"file": "src/zope/schema/_bootstrapfields.py"
... | zopefoundation/zope.schema | 6a3e0dbb446fbe729e4e5db7c233c3d317d4a633 | #87 breaks persistent Text fields
We persist some schemas that use fields. Setting `unicode_normalization` in `Text.__init__` breaks persistent loading of such schemas. | diff --git a/CHANGES.rst b/CHANGES.rst
index a117f0f..15539e2 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,12 @@
Changes
=========
-5.1 (unreleased)
-================
+5.0.1 (unreleased)
+==================
-- Nothing changed yet.
+- Fix: add ``Text.unicode_normalization = 'NFC'`` as default, because s... |
zopefoundation__zope.schema-92 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": [
"src/zope/schema/_field.py:implementer_if_needed.__init__",
"src/zope/schema/_fi... | zopefoundation/zope.schema | 31303705cf63f115b958d2be86e9a9bce296afa8 | Borked interface resolution order for boolean field
If I take a boolean field I would expect IBool to be the first interface,compare the output of the field `__iro__` with other fields.
```
In [23]: ITestContent['_bool'].__provides__.__iro__
Out[23]:
(<InterfaceClass zope.schema._bootstrapinterfaces.IFromUnicode>,... | diff --git a/.gitignore b/.gitignore
index a063dff..f79af92 100644
--- a/.gitignore
+++ b/.gitignore
@@ -1,4 +1,5 @@
*.pyc
+*.pyo
__pycache__
.installed.cfg
bin
diff --git a/.travis.yml b/.travis.yml
index 6e19505..e8ad1da 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -2,21 +2,17 @@ language: python
sudo: false
p... |
zopefoundation__zope.security-24 | [
{
"changes": {
"added_entities": [
"src/zope/security/checker.py:_fixup_dictlike",
"src/zope/security/checker.py:_fixup_odict"
],
"added_modules": [
"src/zope/security/checker.py:_fixup_dictlike",
"src/zope/security/checker.py:_fixup_odict"
],
"edite... | zopefoundation/zope.security | 2b82f83048802017a451d2abcdc2a2bae8ece182 | Iteration of OrderedDict broken under Python 3
Python 3.5 re-implemented OrderedDict in C, which results in it having custom classes for `.keys()`, `.values()`, `.items()` and `__iter__`. Likewise, Python 3 reimplemented OrderedDict to use Python "view classes" for its `__iter__`, etc. These aren't covered by the defau... | diff --git a/CHANGES.rst b/CHANGES.rst
index 0203e6a..aea7438 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,7 +4,12 @@ Changes
4.1.1 (unreleased)
------------------
-- TBD
+- Fix `issue 23 <https://github.com/zopefoundation/zope.security/issues/23>`_:
+ iteration of ``collections.OrderedDict`` and its various v... |
zopefoundation__zope.security-28 | [
{
"changes": {
"added_entities": [
"src/zope/security/checker.py:_fixup_zope_interface"
],
"added_modules": [
"src/zope/security/checker.py:_fixup_zope_interface",
"src/zope/security/checker.py:I1",
"src/zope/security/checker.py:I2",
"src/zope/security/c... | zopefoundation/zope.security | 4e08d85f4ad2d9fb1f1acbe1fad004c81b6d33c0 | Proxied zope.interface.Provides and implementedBy can't be put in a list in Python 3 but can in Py2
This is similar to #23 and #20, except with `__len__`, not `__iter__`. And it only happens in Python 3.
When you write `list(thing)` in CPython 3, CPython will look for the `__len__` slot in the C struct for the objec... | diff --git a/.travis.yml b/.travis.yml
index 92655c1..c5b8cc2 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -17,7 +17,8 @@ env:
- TOXENV=docs
install:
- pip install -U pip
- - pip install -U setuptools tox
+ - pip install -U setuptools
+ - pip install -U tox
script:
- tox
notifications:
diff ... |
zopefoundation__zope.security-31 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/security/proxy.py:ProxyPy.__str__",
"src/zope/security/proxy.py:ProxyPy.__repr__"
],
"edited_modules": [
"src/zope/security/proxy.py:ProxyPy"
]
},
"fil... | zopefoundation/zope.security | f2de4625c116085404958724468899dbe784bce6 | security proxy breaks python expectation w/ str and repr
In https://bugs.launchpad.net/zope.security/+bug/156762, Barry Warsaw (barry@python.org) reported:
> In Python, when an object has a `__repr__()` but no `__str__()`, and `str()` is called on that object, Python will fall back to calling `__repr__()`, as documen... | diff --git a/CHANGES.rst b/CHANGES.rst
index c264be8..0bcf42b 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -4,6 +4,11 @@ Changes
4.1.2 (unreleased)
------------------
+- Fix `issue 7
+ <https://github.com/zopefoundation/zope.security/issues/7`_: The
+ pure-Python proxy didn't propagate ``TypeError`` from ``__rep... |
zopefoundation__zope.security-81 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/security/checker.py"
}
] | zopefoundation/zope.security | fca22bb84b4eaf11875a7a7207fb0c1d9be36d39 | Discrepancy in default method-wrapper checker between Python 2 and 3
I ran into this while porting Launchpad to Python 3, using zope.security 5.1.1. Now that I more or less understand it, I think I can work around it, but it struck me as odd behaviour and I thought I'd try to find out whether it was intentional. The ... | diff --git a/CHANGES.rst b/CHANGES.rst
index 72b74fe..5a7e37a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,10 @@
5.3 (unreleased)
================
-- Nothing changed yet.
+- Allow calling bound methods of some built-in objects such as ``().__repr__``
+ and ``{}.__repr__`` by default. This worked on Python... |
zopefoundation__zope.sendmail-12 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/sendmail/queue.py:ConsoleApp._process_args"
],
"edited_modules": [
"src/zope/sendmail/queue.py:ConsoleApp"
]
},
"file": "src/zope/sendmail/queue.py"
}
] | zopefoundation/zope.sendmail | 6e377f7e9a849bf4b39c416ddc9f7ce010a0785d | Port to argparse
We're still using the deprecated optparse. This will be easier after #7 | diff --git a/CHANGES.rst b/CHANGES.rst
index 3d3de1a..685b9d4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -23,6 +23,11 @@
- Reach 100% test coverage and maintain it via tox.ini and Travis CI.
+- Replaced deprecated dependency on ``optparse`` with equivalent
+ ``argparse``. The help messages have changed and err... |
zopefoundation__zope.sendmail-20 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "src/zope/sendmail/_compat.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zop... | zopefoundation/zope.sendmail | 8ec710588bf3558d3969d22f4fff72c080435aea | Encoding username/password to utf-8 is incompatible with Python 3.6's auth_login
When using zope.sendmail with an SMTP server that will ask you to perform auth_login then this will end in:
``` Python
File "/Users/ctheune/Code/fc.support/lib/python3.6/site-packages/zope/sendmail/mailer.py", line 105, in send
... | diff --git a/CHANGES.rst b/CHANGES.rst
index f15e8cf..5cd15bb 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,7 +5,9 @@
4.3 (unreleased)
================
-- Nothing changed yet.
+- Fix SMTP authentication on Python 3. See `issue 16
+ <https://github.com/zopefoundation/zope.sendmail/issues/16>`_.
+
4.2 (2018-... |
zopefoundation__zope.sendmail-47 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/sendmail/queue.py:QueueProcessorThread._parseMessage"
],
"edited_modules": [
"src/zope/sendmail/queue.py:QueueProcessorThread"
]
},
"file": "src/zope/sendmail/... | zopefoundation/zope.sendmail | 563de51233eff0b4d2d2060641cd6a8a48ea1883 | The mail queue might get stuck
### What I did:
I am using the mailqueue.
This is what I can read in the message stored in the 'myfolder/new' directory.
```
X-Zope-To: Foo <foo@example.com>, , Bar <bar@example.com>
```
As you can see the application crafted a message with empty recipients.
### What I expect t... | diff --git a/CHANGES.rst b/CHANGES.rst
index 5304f54..ea1717a 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -7,6 +7,9 @@
- Add support for Python 3.10.
+- Do not try to send queued emails to an empty address
+ (`#45 <https://github.com/zopefoundation/zope.sendmail/issues/45>`_).
+
5.2 (2021-01-18)
===========... |
zopefoundation__zope.site-11 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
... | zopefoundation/zope.site | a711e599297c8f42044f88137850a2c48b4a29b2 | Fix DeprecationWarnings
e.g.,
```
zope/site/site.py:35: DeprecationWarning: ComponentLookupError is deprecated. Import from zope.interface.interfaces
from zope.component.interfaces import ComponentLookupError
``` | diff --git a/CHANGES.rst b/CHANGES.rst
index 2a49792..1ddb1ad 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -5,14 +5,15 @@
4.2.2 (unreleased)
==================
-- Nothing changed yet.
+- Fix more ``DeprecationWarnings``. See `issue 10
+ <https://github.com/zopefoundation/zope.site/issues/10>`_.
4.2.1 (2018-1... |
zopefoundation__zope.site-18 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
... | zopefoundation/zope.site | c3386aa3762152e0ca3f82dcc52c9b5d90ca1e85 | IRootFolder gives IRoot lower priority than generic container interfaces
Over in https://github.com/zopefoundation/zc.resourcelibrary/issues/6 it was discovered that `IRootFolder` is defined like this:
```python
class IFolder(zope.container.interfaces.IContainer,
zope.component.interfaces.IPossibleSite... | diff --git a/CHANGES.rst b/CHANGES.rst
index a4bfd9a..24c9975 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,17 +2,33 @@
Changes
=========
-4.4.1 (unreleased)
+4.5.0 (unreleased)
==================
-- Nothing changed yet.
+- Fix the interface definition of ``IRootFolder`` to give ``IRoot``
+ higher priority ... |
zopefoundation__zope.tales-8 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/zope/tales/expressions.py:SubPathExpr.__init__",
"src/zope/tales/expressions.py:PathExpr._eval",
"src/zope/tales/expressions.py:LazyWrapper.__init__"
],
"edited_modules":... | zopefoundation/zope.tales | b5f635089bee4ef7b14bb97f090f2cf4763cc9da | Reach 100% coverage | diff --git a/.coveragerc b/.coveragerc
index 5724d01..1e8ed43 100644
--- a/.coveragerc
+++ b/.coveragerc
@@ -1,5 +1,7 @@
[run]
source = zope.tales
+omit =
+ */flycheck_*py
[report]
precision = 2
diff --git a/.travis.yml b/.travis.yml
index b07bcf7..e903051 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -5,12 +5... |
zopefoundation__zope.traversing-11 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "setup.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
... | zopefoundation/zope.traversing | cfaa1fa9f3bed5758b3d8c5a01959bd0ab6295ff | DeprecationWarning: ComponentLookupError is deprecated
```
zope/traversing/namespace.py:70: DeprecationWarning: ComponentLookupError is deprecated. Import from zope.interface.interfaces
from zope.component.interfaces import ComponentLookupError
``` | diff --git a/.gitignore b/.gitignore
index 7fe07b7..bc6e42c 100644
--- a/.gitignore
+++ b/.gitignore
@@ -11,5 +11,6 @@ develop-eggs/
eggs/
parts/
.coverage
+.coverage.*
htmlcov/
docs/_build/
diff --git a/CHANGES.rst b/CHANGES.rst
index 79076a8..c99bcb4 100644
--- a/CHANGES.rst
+++ b/CHANGES.rst
@@ -2,10 +2,12 @@
... |
zpieslak__mobilus-client-18 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobilus_client/app.py:App.__init__"
],
"edited_modules": [
"mobilus_client/app.py:App"
]
},
"file": "mobilus_client/app.py"
},
{
"changes": {
"added_entit... | zpieslak/mobilus-client | 702c41f2e88732f7331e7f68e32e667a7415b3c5 | Move client_id generation out of Config class
Generate unique client_id on each mqtt client initialization, instead of doing it in Config class.
This is first step needed to App class to be more flexible and allow multiple mqtt connections. | diff --git a/mobilus_client/app.py b/mobilus_client/app.py
index 0eae7e0..210eb08 100644
--- a/mobilus_client/app.py
+++ b/mobilus_client/app.py
@@ -1,4 +1,5 @@
import logging
+import secrets
import socket
from mobilus_client.config import Config
@@ -16,7 +17,7 @@ class App:
self.message_registry = Messag... |
zpieslak__mobilus-client-30 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobilus_client/client.py:Client.__init__",
"mobilus_client/client.py:Client.send_request",
"mobilus_client/client.py:Client.on_connect_callback",
"mobilus_client/client.py:Client... | zpieslak/mobilus-client | 1017e022e548b4c51d74a0f061bdd21bd5037e6b | Fix exception in on_message: 'public_key'"
On shared topic `clients` sometimes client A may receive message that was sent by another client B but still client A is not authorized and therefore `public_key` is not available yet.
Ignore message on `clients` topic if client is not authenticated yet.
https://github.... | diff --git a/README.md b/README.md
index e2d2cd6..2ac4ddd 100644
--- a/README.md
+++ b/README.md
@@ -2,7 +2,9 @@
-This code provides a native Python client for the Mobilus Cosmo GTW. It connects directly to the gatewa... |
zpieslak__mobilus-client-32 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"mobilus_client/client.py:Client.on_message_callback"
],
"edited_modules": [
"mobilus_client/client.py:Client"
]
},
"file": "mobilus_client/client.py"
},
{
"chan... | zpieslak/mobilus-client | 3dbb9adc147182372819890c60255d7e2682715e | Do not record message on shared topic when is not expected
It looks like when message is received on shared topic (from other pararell run) it is recorded in client message registry instance.
- Do not record mesage if is not expected with request
- Compare CallEventsRequest with deviceId and value | diff --git a/mobilus_client/client.py b/mobilus_client/client.py
index 0343c4f..039a314 100644
--- a/mobilus_client/client.py
+++ b/mobilus_client/client.py
@@ -96,17 +96,16 @@ class Client:
def on_message_callback(self, _client: mqtt.Client, _userdata: None, mqtt_message: mqtt.MQTTMessage) -> None:
logge... |
zulip__zulip-terminal-1122 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/cli/run.py:main"
],
"edited_modules": [
"zulipterminal/cli/run.py:main"
]
},
"file": "zulipterminal/cli/run.py"
},
{
"changes": {
"added_ent... | zulip/zulip-terminal | c9a59fa799c9608be546c4e4709ee052bd62a04f | add option to disable debug.log
Currently, `debug.log` is created wherever the current directory is, and if there are no errors, it is a 0B empty file, even if zulip-term is launched without the `-d` flag.
I would like the creation of `debug.log` to be tied to that `-d` flag, as it gets messy and annoying after a ... | diff --git a/README.md b/README.md
index 9da2352..b70ef96 100644
--- a/README.md
+++ b/README.md
@@ -321,17 +321,15 @@ For additional help with pytest options see `pytest -h`, or check out the [full
#### Output using `print`
-The stdout for zulip-terminal is redirected to `./debug.log` by default.
+The stdout (sta... |
zulip__zulip-terminal-1162 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/model.py:Model._handle_reaction_event"
],
"edited_modules": [
"zulipterminal/model.py:Model"
]
},
"file": "zulipterminal/model.py"
}
] | zulip/zulip-terminal | 4318eb3c97c4faa8baac340faae9ff17256f9627 | KeyError: 'flags'
The following error was in my zulip-terminal-thread-exceptions.log:
Traceback (most recent call last):
File "/Users/kellyfoulk/Documents/code/zulip-te... | diff --git a/zulipterminal/model.py b/zulipterminal/model.py
index a53d2a6..f098e66 100644
--- a/zulipterminal/model.py
+++ b/zulipterminal/model.py
@@ -1427,7 +1427,7 @@ class Model:
assert event["type"] == "reaction"
message_id = event["message_id"]
# If the message is indexed
- if s... |
zulip__zulip-terminal-1194 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "zulipterminal/config/keys.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipte... | zulip/zulip-terminal | 0615735aa9cb177ae6fad9438c48f7b2bdf76815 | Support 'Narrow to current compose box recipient'
This is useful if starting a new topic - currently we give a notice that the sent message is outside of the current narrow, but there is no easy way of jumping to it.
The web app supports <kbd>ctrl</kbd>+<kbd>.</kbd> for achieving this, so this is a logical feature f... | diff --git a/docs/hotkeys.md b/docs/hotkeys.md
index edc75eb..c49cb15 100644
--- a/docs/hotkeys.md
+++ b/docs/hotkeys.md
@@ -80,6 +80,7 @@
|Save current message as a draft|<kbd>meta</kbd> + <kbd>s</kbd>|
|Autocomplete @mentions, #stream_names, :emoji: and topics|<kbd>ctrl</kbd> + <kbd>f</kbd>|
|Cycle through autocom... |
zulip__zulip-terminal-1196 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/core.py:Controller.open_in_browser",
"zulipterminal/core.py:Controller.report_error",
"zulipterminal/core.py:Controller.report_success",
"zulipterminal/core.py:Cont... | zulip/zulip-terminal | 13a1a4c5bc8cb849c67fd0e303f1b0a2ee0a7088 | Improve reporting upon moving/splitting topics
Currently a message is given to the user when a topic is moved, but we could give more information about this:
- where from?
- where to?
- how many? (all? some?)
For the first version of this, updating the text we output would be sufficient.
As a follow-up, we cou... | diff --git a/zulipterminal/core.py b/zulipterminal/core.py
index bde77a4..7c44f95 100644
--- a/zulipterminal/core.py
+++ b/zulipterminal/core.py
@@ -8,7 +8,7 @@ from collections import OrderedDict
from functools import partial
from platform import platform
from types import TracebackType
-from typing import Any, Dic... |
zulip__zulip-terminal-1213 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/boxes.py:MessageBox.reactions_view"
],
"edited_modules": [
"zulipterminal/ui_tools/boxes.py:MessageBox"
]
},
"file": "zulipterminal/ui_tools/boxe... | zulip/zulip-terminal | 8469cdd226a36334d9ecadb2d2f33d2e4b52ae16 | Display names of reacting users when few users have reacted in ZT
To display reacting users when few users have reacted, as shown below -
| diff --git a/zulipterminal/ui_tools/boxes.py b/zulipterminal/ui_tools/boxes.py
index 990290e..12f8a53 100644
--- a/zulipterminal/ui_tools/boxes.py
+++ b/zulipterminal/ui_tools/boxes.py
@@ -1112,18 +1112,31 @@ class MessageBox(urwid.Pile):
if not reactions:
return ""
try:
+ MAXI... |
zulip__zulip-terminal-1224 | [
{
"changes": {
"added_entities": [
"zulipterminal/core.py:Controller.show_media_confirmation_popup"
],
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"zulipterminal/core.py:Controller"
]
},
"file": "zulipterminal/core.py"
},
{
... | zulip/zulip-terminal | 3dcc08e0d4d3c52519594ea7d52c37d21bd54f7c | Document intentional design choices where different from webapp/mobile
This issue has some overlaps with the idea of having tutorials or extra documentation along these lines, but my thought for this issue would be a small section in the README indicating eg. how ZT is keyboard driven and only incidentally mouse-access... | diff --git a/README.md b/README.md
index 21046d6..eda79f0 100644
--- a/README.md
+++ b/README.md
@@ -29,6 +29,17 @@ Learn how to use Zulip Terminal with our [Tutorial](https://github.com/zulip/zul
We consider the client to already provide a fairly stable moderately-featureful everyday-user experience.
+The termina... |
zulip__zulip-terminal-1237 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"zulipterminal/api_types.py:Subscription"
]
},
"file": "zulipterminal/api_types.py"
},
{
"changes": {
"added_entities": null,
"added_module... | zulip/zulip-terminal | 898bb2e3722567f6a4f4bcc0730f2ad77cfa9d9f | TRACKING: Update to use modern API elements (retaining support to 2.1)
There are various situations where we currently use older elements of the API which have been deprecated. We should migrate to the newer forms, while possibly retaining (or extending) compatibility down to our stated lowest supported version if the ... | diff --git a/zulipterminal/api_types.py b/zulipterminal/api_types.py
index 17dc1a1..727bdb8 100644
--- a/zulipterminal/api_types.py
+++ b/zulipterminal/api_types.py
@@ -79,8 +79,7 @@ class Subscription(TypedDict):
pin_to_top: bool
email_address: str
- is_muted: bool # NOTE: new in Zulip 2.1 (in_home_vie... |
zulip__zulip-terminal-1260 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/model.py:Model._handle_subscription_event"
],
"edited_modules": [
"zulipterminal/model.py:Model"
]
},
"file": "zulipterminal/model.py"
}
] | zulip/zulip-terminal | 01b3853c45260bcc5dc0174d6a028e8d9c03fc50 | Migrate to subscription update events with `is_muted` property
In [Zulip 2.1.0](https://zulip.com/api/changelog#changes-in-zulip-21), the `is_muted` stream subscription property was added and replaced the `in_home_view` property. But the server had still only been sending [subscription update events](https://zulip.com/... | diff --git a/zulipterminal/model.py b/zulipterminal/model.py
index 8fabfb8..36507cc 100644
--- a/zulipterminal/model.py
+++ b/zulipterminal/model.py
@@ -1287,23 +1287,35 @@ class Model:
if event["op"] == "update":
if hasattr(self.controller, "view"):
- # NOTE: Currently, the respo... |
zulip__zulip-terminal-1320 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/cli/run.py:get_login_id",
"zulipterminal/cli/run.py:get_api_key",
"zulipterminal/cli/run.py:fetch_zuliprc"
],
"edited_modules": [
"zulipterminal/cli/run... | zulip/zulip-terminal | f1343bca26008a78549f7c917ba53845aca183d9 | On login, providing zulip server prefixed by http:// or https:// manifests in incorrect username/password error
On running zulip-term for the first time:
```
(zulip_terminal_pyvenv) [ahelwer@node ~]$ zulip-term
zuliprc file was not found at /home/ahelwer/zuliprc
Please enter your credentials to login into your Zuli... | diff --git a/zulipterminal/cli/run.py b/zulipterminal/cli/run.py
index 8880ac0..225f37d 100755
--- a/zulipterminal/cli/run.py
+++ b/zulipterminal/cli/run.py
@@ -11,7 +11,7 @@ import sys
import traceback
from enum import Enum
from os import path, remove
-from typing import Dict, List, NamedTuple, Optional, Tuple
+fro... |
zulip__zulip-terminal-1322 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "zulipterminal/config/keys.py"
},
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipte... | zulip/zulip-terminal | 6cd0fc89e4b15ee43ce81393dbd0873597c5f907 | Migrate UI & docs from "Private Messages" to "Direct Messages" text
For motivation see [#**design > "private" vs "direct"**](https://chat.zulip.org/#narrow/stream/101-design/topic/.22Private.22.20vs.20.22Direct.22). Marking only for discussion for now.
This will initially be a straightforward change in the UI only.
... | diff --git a/README.md b/README.md
index 0a9fcee..f972222 100644
--- a/README.md
+++ b/README.md
@@ -43,7 +43,7 @@ The terminal client currently has a number of intentional differences to the Zul
[Hot keys](https://github.com/zulip/zulip-terminal/blob/main/docs/hotkeys.md)
to better support keyboard-only navigati... |
zulip__zulip-terminal-1350 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/views.py:MsgInfoView.__init__"
],
"edited_modules": [
"zulipterminal/ui_tools/views.py:MsgInfoView"
]
},
"file": "zulipterminal/ui_tools/views.py... | zulip/zulip-terminal | b89def63d642cecd4fa6e1d1a9d01a2f001afe2c | Message information popup: Tidy shortcut key text & place into a group
The current shortcut/hotkey list in the message information popup (`i` on a message) could be improved by:
- moving the current hotkey lines into a separate display-group, maybe titled 'Viewing Actions'
- simplifying the text in each entry, includ... | diff --git a/zulipterminal/ui_tools/views.py b/zulipterminal/ui_tools/views.py
index 1ae51ec..8f6ad15 100644
--- a/zulipterminal/ui_tools/views.py
+++ b/zulipterminal/ui_tools/views.py
@@ -1520,13 +1520,15 @@ class MsgInfoView(PopUpView):
date_and_time = controller.model.formatted_local_time(
msg[... |
zulip__zulip-terminal-1352 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/helper.py:index_messages",
"zulipterminal/helper.py:notify_if_message_sent_outside_narrow"
],
"edited_modules": [
"zulipterminal/helper.py:index_messages",
... | zulip/zulip-terminal | 1bc123694255826a8ecde2c93ab1be05caf4ec1b | cannot narrow to 'pm_with'
Due to recent changes in [zerver](https://github.com/zulip/zulip/pull/24775/),the narrow operator `pm_with` is not functional and ZT codebase needs to change it's occurrences to `pm-with`. | diff --git a/zulipterminal/helper.py b/zulipterminal/helper.py
index 896e813..c9817fc 100644
--- a/zulipterminal/helper.py
+++ b/zulipterminal/helper.py
@@ -423,7 +423,7 @@ def index_messages(messages: List[Message], model: Any, index: Index) -> Index:
{recipient["id"] for recipient in msg["display... |
zulip__zulip-terminal-1356 | [
{
"changes": {
"added_entities": [
"zulipterminal/model.py:Model.stream_topic_from_message_id",
"zulipterminal/model.py:Model.next_unread_topic_from_message_id"
],
"added_modules": null,
"edited_entities": [
"zulipterminal/model.py:Model.__init__",
"zulipt... | zulip/zulip-terminal | 2781e34514be0e606a3f88ebf8fd409781d9f625 | Improve algorithm for 'next unread topic' (n) to use current message state
This is intended as a first step to resolving #1332. Please focus on this element of that issue first, and if things go well, then extending the algorithm further to resolve the remaining elements would be great as followup PR(s).
The current... | diff --git a/zulipterminal/model.py b/zulipterminal/model.py
index 82d809a..7073e4f 100644
--- a/zulipterminal/model.py
+++ b/zulipterminal/model.py
@@ -2,6 +2,7 @@
Defines the `Model`, fetching and storing data retrieved from the Zulip server
"""
+import bisect
import itertools
import json
import time
@@ -111,7... |
zulip__zulip-terminal-1382 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "zulipterminal/config/keys.py"
},
{
"changes": {
"added_entities": [
"zulipterminal/model.py:Model.stream_topic_from_message_id",
... | zulip/zulip-terminal | 2781e34514be0e606a3f88ebf8fd409781d9f625 | Support new `=` keyboard shortcut for 'reaction agreement'
This is the equivalent of zulip/zulip#24266 for this project.
Also see zulip/zulip#24828 for the related documentation, which should accompany this. | diff --git a/docs/hotkeys.md b/docs/hotkeys.md
index c9677e8..38ad92b 100644
--- a/docs/hotkeys.md
+++ b/docs/hotkeys.md
@@ -55,6 +55,7 @@
|Narrow to the stream of the current message|<kbd>s</kbd>|
|Narrow to the topic of the current message|<kbd>S</kbd>|
|Narrow to a topic/direct-chat, or stream/all-direct-messages... |
zulip__zulip-terminal-1385 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/helper.py:match_topics"
],
"edited_modules": [
"zulipterminal/helper.py:match_topics"
]
},
"file": "zulipterminal/helper.py"
}
] | zulip/zulip-terminal | f420528f13ce37b4dc5b5939b10f9f11d1a39c10 | Support multi-word matching when autocompleting topics
When autocompleting other items such as streams, we check the search term against different 'words' in the possible matches. For example, `doc` can match both `documentation` and `api documentation`, `cod` can match `code review` and `live coding`, and `term` can m... | diff --git a/zulipterminal/helper.py b/zulipterminal/helper.py
index c9817fc..12f402b 100644
--- a/zulipterminal/helper.py
+++ b/zulipterminal/helper.py
@@ -535,9 +535,20 @@ def match_emoji(emoji: str, text: str) -> bool:
def match_topics(topic_names: List[str], search_text: str) -> List[str]:
- return [
- ... |
zulip__zulip-terminal-1404 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "zulipterminal/config/keys.py"
},
{
"changes": {
"added_entities": [
"zulipterminal/core.py:Controller.show_msg_sender_info"
],
... | zulip/zulip-terminal | 5d34ef0484c867167758404087909b7f262f220f | Show user popup for sender of message on `u` hotkey
This would match the behavior in the web app.
Look for the way in which this popup is opened from the user list, and apply the same approach but using the sender of message (only if one is selected).
Note that this is not `U`, which will be a key we use for mar... | diff --git a/docs/hotkeys.md b/docs/hotkeys.md
index db49720..c9677e8 100644
--- a/docs/hotkeys.md
+++ b/docs/hotkeys.md
@@ -58,6 +58,7 @@
|Add/remove thumbs-up reaction to the current message|<kbd>+</kbd>|
|Add/remove star status of the current message|<kbd>ctrl</kbd> + <kbd>s</kbd> / <kbd>*</kbd>|
|Show/hide messa... |
zulip__zulip-terminal-1424 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/buttons.py:MessageLinkButton._parse_narrow_link"
],
"edited_modules": [
"zulipterminal/ui_tools/buttons.py:MessageLinkButton"
]
},
"file": "zulip... | zulip/zulip-terminal | b11ea7b3d0efb2c11537436083bb353688aa156b | Support old format for narrow links (subject in addition to topic)
As documented in buttons.py (currently `_parse_narrow_link`), we support links formatted in the form:
```
... narrow/stream/[{stream-id}-]{stream-name}/topic/{encoded.20.topic.20name}[/near/{message_id}]
```
As I noted in [**#api documentation > N... | diff --git a/zulipterminal/ui_tools/buttons.py b/zulipterminal/ui_tools/buttons.py
index fe21169..3fd8b97 100644
--- a/zulipterminal/ui_tools/buttons.py
+++ b/zulipterminal/ui_tools/buttons.py
@@ -493,12 +493,17 @@ class MessageLinkButton(urwid.Button):
"""
# NOTE: The optional stream_id link version ... |
zulip__zulip-terminal-1432 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/cli/run.py:main"
],
"edited_modules": [
"zulipterminal/cli/run.py:main"
]
},
"file": "zulipterminal/cli/run.py"
},
{
"changes": {
"added_ent... | zulip/zulip-terminal | abdc4541ee39f44603b5ae40be8fc752591144b6 | Add popup to confirm exiting the application
I raised a concern over this some time ago in [#zulip-terminal>Confirm before exiting? #T1341](https://chat.zulip.org/#narrow/stream/206-zulip-terminal/topic/Confirm.20before.20exiting.3F.20.23T1341); see there for motivation.
The design for this could be as follows:
- r... | diff --git a/README.md b/README.md
index c59e351..5763df6 100644
--- a/README.md
+++ b/README.md
@@ -232,6 +232,9 @@ theme=zt_dark
## Autohide: set to 'autohide' to hide the left & right panels except when they're focused
autohide=no_autohide
+## Exit Confirmation: set to 'disabled' to exit directly with no warning... |
zulip__zulip-terminal-1449 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/messages.py:MessageBox.soup2markup"
],
"edited_modules": [
"zulipterminal/ui_tools/messages.py:MessageBox"
]
},
"file": "zulipterminal/ui_tools/m... | zulip/zulip-terminal | eee60796aa7b3d72d0e2ffe950853958e6832aa7 | Render @topic wildcard mentions correctly when displayed in a message feed.
[CZO discussion](https://chat.zulip.org/#narrow/stream/378-api-design/topic/.40topic-mention.20data-user-id.20.2326195/near/1605762)
For stream wildcard mentions (all, everyone, stream), the rendered content is:
```
<span class="user-menti... | diff --git a/zulipterminal/ui_tools/messages.py b/zulipterminal/ui_tools/messages.py
index 1598306..1a9bb9d 100644
--- a/zulipterminal/ui_tools/messages.py
+++ b/zulipterminal/ui_tools/messages.py
@@ -442,9 +442,10 @@ class MessageBox(urwid.Pile):
markup.append(("msg_math", tag_text))
el... |
zulip__zulip-terminal-1459 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": [
"zulipterminal/api_types.py:PrivateComposition",
"zulipterminal/api_types.py:StreamComposition"
]
},
"file": "zulipterminal/api_types.py"
},
{
... | zulip/zulip-terminal | 107fa9b814fb6db6c4b5405faea1de727f8ceb04 | Pass new `read_by_sender` flag when sending messages
See https://zulip.com/api/send-message#parameter-read_by_sender and https://chat.zulip.org/#narrow/stream/378-api-design/topic/read_by_sender.20flag.20on.20send-message/near/1702407 for details. | diff --git a/zulipterminal/api_types.py b/zulipterminal/api_types.py
index b341993..7e102e3 100644
--- a/zulipterminal/api_types.py
+++ b/zulipterminal/api_types.py
@@ -93,6 +93,7 @@ class PrivateComposition(TypedDict):
type: DirectMessageString
content: str
to: List[int] # User ids
+ read_by_sender:... |
zulip__zulip-terminal-1468 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/messages.py:MessageBox.keypress"
],
"edited_modules": [
"zulipterminal/ui_tools/messages.py:MessageBox"
]
},
"file": "zulipterminal/ui_tools/mess... | zulip/zulip-terminal | da84485cfc011c13e4177cc56442eeb04d83302d | [bug] crash when editing message
Server: Zulip cloud server
Client: main branch
Python: 3.11
self.model.initial_data: `{'zulip_version': '9.0-dev-642-g9d469357ea', 'zulip_feature_level': 237, 'zulip_merge_base': '9.0-dev-605-g47a5459637', 'realm_message_content_edit_limit_seconds': None}`
log:
```
Traceback (most... | diff --git a/zulipterminal/ui_tools/messages.py b/zulipterminal/ui_tools/messages.py
index 1a9bb9d..3ddfa10 100644
--- a/zulipterminal/ui_tools/messages.py
+++ b/zulipterminal/ui_tools/messages.py
@@ -1045,12 +1045,12 @@ class MessageBox(urwid.Pile):
# the time limit. A limit of 0 signifies no limit
... |
zulip__zulip-terminal-1472 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/core.py:Controller.open_in_browser"
],
"edited_modules": [
"zulipterminal/core.py:Controller"
]
},
"file": "zulipterminal/core.py"
}
] | zulip/zulip-terminal | b71aec23f78c487506e86bbd5a89b90c5b3d61ec | ZT Crashes when viewing a message in browser in MacOS.
<img width="1031" alt="Screenshot 2024-02-15 at 9 44 55 PM" src="https://github.com/zulip/zulip-terminal/assets/71403193/deeadd45-decb-42f5-880c-30f709268a29">
ZT crashes when viewing a message in browser on MacOS.
My OS version = Ventura 13.6
Python version... | diff --git a/zulipterminal/core.py b/zulipterminal/core.py
index ddc7e89..1e11354 100644
--- a/zulipterminal/core.py
+++ b/zulipterminal/core.py
@@ -414,11 +414,14 @@ class Controller:
# Suppress stdout and stderr when opening browser
with suppress_output():
browser_controller... |
zulip__zulip-terminal-748 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui.py:View.set_footer_text"
],
"edited_modules": [
"zulipterminal/ui.py:View"
]
},
"file": "zulipterminal/ui.py"
}
] | zulip/zulip-terminal | 80bb9c0d75f56db98b06da96af411425c75a7304 | Footer gets updated as many times as the edit key is pressed on any uneditable message
Steps to reproduce:
* Move focus to any message that you can't edit
* Press e multiple times
* Press any other key to trigger the behaviour | diff --git a/zulipterminal/ui.py b/zulipterminal/ui.py
index d998569..544f9d7 100644
--- a/zulipterminal/ui.py
+++ b/zulipterminal/ui.py
@@ -103,6 +103,11 @@ class View(urwid.WidgetWrap):
style: str = "footer",
duration: Optional[float] = None,
) -> None:
+ # Avoid updating repeatedly (the... |
zulip__zulip-terminal-928 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/ui_tools/boxes.py:WriteBox.autocomplete_users"
],
"edited_modules": [
"zulipterminal/ui_tools/boxes.py:WriteBox"
]
},
"file": "zulipterminal/ui_tools/boxe... | zulip/zulip-terminal | e1bdf749195dfa9dec843ec9132f79652147c510 | Create extended user mention syntax when needed.
Recently, in zulip/zulip#10243 we merged support for the following mention syntax to zulip/zulip:
`@**Full Name|1234(id)**`
This is to allow us to mention users with the same full name, and is optional. The web app intelligently adds the new syntax only when the us... | diff --git a/zulipterminal/ui_tools/boxes.py b/zulipterminal/ui_tools/boxes.py
index 85a50a5..fab9cf9 100644
--- a/zulipterminal/ui_tools/boxes.py
+++ b/zulipterminal/ui_tools/boxes.py
@@ -1,7 +1,7 @@
import re
import typing
import unicodedata
-from collections import OrderedDict, defaultdict
+from collections impor... |
zulip__zulip-terminal-967 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"zulipterminal/core.py:Controller._narrow_to"
],
"edited_modules": [
"zulipterminal/core.py:Controller"
]
},
"file": "zulipterminal/core.py"
}
] | zulip/zulip-terminal | 1c64a7ce892643165b72a63fb929db3a76effd91 | Narrowing with a contextual message id should select that message
If using a link such as generated in a quoted message, then the UI doesn't select that message - which seems like the behavior to be expected.
To reproduce:
* quote a message and send it
* move cursor onto message with quote
* open message info pop... | diff --git a/zulipterminal/core.py b/zulipterminal/core.py
index c503aa4..8486b4d 100644
--- a/zulipterminal/core.py
+++ b/zulipterminal/core.py
@@ -386,13 +386,16 @@ class Controller:
def _narrow_to(self, anchor: Optional[int], **narrow: Any) -> None:
already_narrowed = self.model.set_narrow(**narrow)
... |
zulip__zulip-terminal-971 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": null,
"edited_modules": null
},
"file": "zulipterminal/config/themes.py"
},
{
"changes": {
"added_entities": [
"zulipterminal/core.py:Controller.report_error",
"zulipter... | zulip/zulip-terminal | 9280f09c3391e11b8f9ae553563fe11d22c2c3c9 | Support a variety of footer notification styling
We can consider styling of footer notifications, eg. to distinguish errors/warnings from simple notifications like #781, and we could even add a positive one for "message sent" type notifications. | diff --git a/zulipterminal/config/themes.py b/zulipterminal/config/themes.py
index b6fdb13..2c8dafa 100644
--- a/zulipterminal/config/themes.py
+++ b/zulipterminal/config/themes.py
@@ -36,6 +36,7 @@ required_styles = { # style-name: monochrome-bit-depth-style
"msg_bold": "bold",
"msg_time": "bold",
"foo... |
zurutech__ashpy-35 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ashpy/metrics/classifier.py:ClassifierLoss.__init__"
],
"edited_modules": [
"src/ashpy/metrics/classifier.py:ClassifierLoss"
]
},
"file": "src/ashpy/metrics/classif... | zurutech/ashpy | b5d7215abca4004afec8263abfaa1ca3bb8c8079 | [BUG] - Unable to do model selection on a decreasing metric
**Describe the bug**
I expect to be able to do model selecting, using the classifier loss as metric. Actually, I find only a JSON with this content:
> cat ~/log/on/best/loss/loss.json
```
{
"loss": "-inf",
"step": "0"
}
```
**Expected b... | diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md
index cbe50ad..45c89dc 100644
--- a/.github/pull_request_template.md
+++ b/.github/pull_request_template.md
@@ -19,7 +19,7 @@ Fixes # (issue)
Please delete options that are not relevant.
-- [ ] Bug fix (i.e., a non-breaking change whi... |
zurutech__ashpy-38 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"examples/gans/pix2pix_facades.py:main"
],
"edited_modules": [
"examples/gans/pix2pix_facades.py:main"
]
},
"file": "examples/gans/pix2pix_facades.py"
},
{
"chan... | zurutech/ashpy | f437294c24fa2622558e549e157eac65072960d2 | No such file or directory checkpoint_map.json when restoring model from model selection
The title says pretty much everything.
Creating a restorer (in particular a ClassifierRestorer but it is not important) passing as checkpoint directory, the directory where the checkpoint of the best model has been saved causes a... | diff --git a/examples/gans/pix2pix_facades.py b/examples/gans/pix2pix_facades.py
index 5254933..b9f00be 100644
--- a/examples/gans/pix2pix_facades.py
+++ b/examples/gans/pix2pix_facades.py
@@ -17,7 +17,7 @@ Pix2Pix on Facades Datasets dummy implementation.
Input Pipeline taken from: https://www.tensorflow.org/beta/t... |
zurutech__ashpy-44 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ashpy/contexts/classifier.py:ClassifierContext.__init__"
],
"edited_modules": [
"src/ashpy/contexts/classifier.py:ClassifierContext"
]
},
"file": "src/ashpy/context... | zurutech/ashpy | 7dc0b4021d0ee3dd13272fd76e08fa30b041ae40 | The model selection JSON file is overwritten with defaults on re-start
Scenario:
- You're training a model and doing model selection
- You stop the train
- You re-start the train
The JSON file of the model selection is overwritten with default values, making you lost the previously (correctly stored) value. | diff --git a/src/ashpy/contexts/classifier.py b/src/ashpy/contexts/classifier.py
index 649bb33..27588ca 100644
--- a/src/ashpy/contexts/classifier.py
+++ b/src/ashpy/contexts/classifier.py
@@ -16,7 +16,7 @@
from __future__ import annotations
-from typing import TYPE_CHECKING, List, Optional
+from typing import TYP... |
zurutech__ashpy-51 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"src/ashpy/metrics/gan.py:InceptionScore.inception_score"
],
"edited_modules": [
"src/ashpy/metrics/gan.py:InceptionScore"
]
},
"file": "src/ashpy/metrics/gan.py"
},
... | zurutech/ashpy | df17d72449dfda73bcc70c31c3c2702c266aa3d7 | Precision of comparison when doing model selection
See the following log:
```
AEAccuracy: validation value: 0.49551415 → 0.4955141544342041
[960] loss: 0.04510442167520523
AEAccuracy: validation value: 0.49551415 → 0.4955141544342041
[970] loss: 0.04019254446029663
AEAccuracy: validation value: 0.49551415 → 0.4... | diff --git a/src/ashpy/metrics/gan.py b/src/ashpy/metrics/gan.py
index 02eb008..691515a 100644
--- a/src/ashpy/metrics/gan.py
+++ b/src/ashpy/metrics/gan.py
@@ -341,7 +341,7 @@ class InceptionScore(Metric):
:obj:`tuple` of (:py:class:`numpy.ndarray`, :py:class:`numpy.ndarray`): Mean and STD.
"""... |
zwicker-group__py-pde-435 | [
{
"changes": {
"added_entities": [
"pde/storage/base.py:StorageTracker._transform"
],
"added_modules": null,
"edited_entities": [
"pde/storage/base.py:StorageBase.tracker",
"pde/storage/base.py:StorageTracker.__init__",
"pde/storage/base.py:StorageTracker.... | zwicker-group/py-pde | 95932603a3b15d44c4f5ef6c76ed6ab463d8aa44 | Add option for transformer function to `StorageTracker`
`StorageTracker` should not only be able to store the actual fields of the simulations, but also some derived fields. The idea would be to add an argument to the StoragerTracker which could take a function that computes a field or field collection based on the cur... | diff --git a/pde/storage/base.py b/pde/storage/base.py
index 10ec98c..d5d12aa 100644
--- a/pde/storage/base.py
+++ b/pde/storage/base.py
@@ -266,18 +266,30 @@ class StorageBase(metaclass=ABCMeta):
@fill_in_docstring
def tracker(
- self, interval: Union[int, float, InterruptsBase] = 1
+ self,
+... |
zwicker-group__py-pde-683 | [
{
"changes": {
"added_entities": null,
"added_modules": null,
"edited_entities": [
"pde/trackers/base.py:TrackerBase.initialize"
],
"edited_modules": [
"pde/trackers/base.py:TrackerBase"
]
},
"file": "pde/trackers/base.py"
}
] | zwicker-group/py-pde | 69fe10cfeaa20dd9454bfa8e9adfa9769026baae | Wrong storage times for explicit/implicit integrator with an interval time range
### Discussed in https://github.com/zwicker-group/py-pde/discussions/681
<div type='discussions-op-text'>
<sup>Originally posted by **nyuhanc** March 21, 2025</sup>
Hello,
first thank you for writing this nice repo. I think I have foun... | diff --git a/pde/trackers/base.py b/pde/trackers/base.py
index b5bdec1..a15b47a 100644
--- a/pde/trackers/base.py
+++ b/pde/trackers/base.py
@@ -92,7 +92,7 @@ class TrackerBase(metaclass=ABCMeta):
float: The first time the tracker needs to handle data
"""
if info is not None:
- ... |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.